Deprecate listIncompleteUploads() and removeIncompleteUploads() #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
Deprecate-listIncompleteUploads-and-removeIncomplete
branch
3 times, most recently
from
5d7ffe4
to
431eec8
Compare
kannappanr
previously approved these changes
Jun 26, 2020
balamurugana
force-pushed
the
Deprecate-listIncompleteUploads-and-removeIncomplete
branch
from
431eec8
to
8dd5b5c
Compare
|
@balamurugana Can you please re-run the jobs or look into the failures? |
balamurugana
force-pushed
the
Deprecate-listIncompleteUploads-and-removeIncomplete
branch
from
8dd5b5c
to
0edb419
Compare
Public methods in MinioClient does not leave incomplete uploads on failures. Hence `listIncompleteUploads()` and `removeIncompleteUploads()` are deprecated and will be removed later. However protected methods `listMultipartUploads()`, `listParts()` and `abortMultipartUpload()` in MinioClient are available by inheritance for developers.
balamurugana
force-pushed
the
Deprecate-listIncompleteUploads-and-removeIncomplete
branch
from
0edb419
to
04aaf08
Compare
|
Already taken care by #992 |
balamurugana
deleted the
Deprecate-listIncompleteUploads-and-removeIncomplete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public methods in MinioClient does not leave incomplete uploads on
failures. Hence
listIncompleteUploads()andremoveIncompleteUploads()are deprecated and will be removed later.However protected methods
listMultipartUploads(),listParts()andabortMultipartUpload()in MinioClient are available byinheritance for developers.