Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle region and extra headers/query parameters in low level APIs #992

Conversation

balamurugana
Copy link
Member

No description provided.

@balamurugana balamurugana force-pushed the Handle-region-and-extra-headers-query-parameters-in-low-level-APis branch from 71e2bb7 to 5c14269 Compare June 26, 2020 05:54
@balamurugana balamurugana changed the title Handle region and extra headers/query parameters in low level APis Handle region and extra headers/query parameters in low level APIs Jun 26, 2020
@balamurugana balamurugana force-pushed the Handle-region-and-extra-headers-query-parameters-in-low-level-APis branch from 5c14269 to e8dc2a5 Compare June 26, 2020 06:02
kannappanr
kannappanr previously approved these changes Jun 26, 2020
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the Handle-region-and-extra-headers-query-parameters-in-low-level-APis branch 2 times, most recently from 7ae792a to abc9030 Compare June 26, 2020 15:27
@kannappanr kannappanr requested a review from BigUstad July 1, 2020 09:14
@balamurugana balamurugana force-pushed the Handle-region-and-extra-headers-query-parameters-in-low-level-APis branch from abc9030 to 935d2ba Compare July 2, 2020 04:55
@BigUstad
Copy link
Contributor

BigUstad commented Jul 6, 2020

@balamurugana Please resolve conflicts.

Public methods in MinioClient does not leave incomplete uploads on
failures. Hence `listIncompleteUploads()` and
`removeIncompleteUploads()` are deprecated and will be removed later.

However protected methods `listMultipartUploads()`, `listParts()` and
`abortMultipartUpload()` in MinioClient are available by
inheritance for developers.
@balamurugana balamurugana force-pushed the Handle-region-and-extra-headers-query-parameters-in-low-level-APis branch from 935d2ba to f50a9c7 Compare July 6, 2020 17:33
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 1b115cb into minio:master Jul 7, 2020
@balamurugana balamurugana deleted the Handle-region-and-extra-headers-query-parameters-in-low-level-APis branch July 7, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants