-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle region and extra headers/query parameters in low level APIs #992
Merged
kannappanr
merged 9 commits into
minio:master
from
balamurugana:Handle-region-and-extra-headers-query-parameters-in-low-level-APis
Jul 7, 2020
Merged
Handle region and extra headers/query parameters in low level APIs #992
kannappanr
merged 9 commits into
minio:master
from
balamurugana:Handle-region-and-extra-headers-query-parameters-in-low-level-APis
Jul 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
force-pushed
the
Handle-region-and-extra-headers-query-parameters-in-low-level-APis
branch
from
June 26, 2020 05:54
71e2bb7
to
5c14269
Compare
balamurugana
changed the title
Handle region and extra headers/query parameters in low level APis
Handle region and extra headers/query parameters in low level APIs
Jun 26, 2020
balamurugana
force-pushed
the
Handle-region-and-extra-headers-query-parameters-in-low-level-APis
branch
from
June 26, 2020 06:02
5c14269
to
e8dc2a5
Compare
kannappanr
previously approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
balamurugana
force-pushed
the
Handle-region-and-extra-headers-query-parameters-in-low-level-APis
branch
2 times, most recently
from
June 26, 2020 15:27
7ae792a
to
abc9030
Compare
balamurugana
force-pushed
the
Handle-region-and-extra-headers-query-parameters-in-low-level-APis
branch
from
July 2, 2020 04:55
abc9030
to
935d2ba
Compare
@balamurugana Please resolve conflicts. |
fix protected uploadPartCopy()
Public methods in MinioClient does not leave incomplete uploads on failures. Hence `listIncompleteUploads()` and `removeIncompleteUploads()` are deprecated and will be removed later. However protected methods `listMultipartUploads()`, `listParts()` and `abortMultipartUpload()` in MinioClient are available by inheritance for developers.
balamurugana
force-pushed
the
Handle-region-and-extra-headers-query-parameters-in-low-level-APis
branch
from
July 6, 2020 17:33
935d2ba
to
f50a9c7
Compare
BigUstad
approved these changes
Jul 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
harshavardhana
approved these changes
Jul 6, 2020
balamurugana
deleted the
Handle-region-and-extra-headers-query-parameters-in-low-level-APis
branch
July 7, 2020 08:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.