-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Reading TLS certificates when deployed in K8S #10601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
force-pushed
the
certificates-symlinks
branch
from
September 30, 2020 02:42
33d079f
to
d322fae
Compare
Ignore all regular files, CAs directory and any directory that starts with `..` inside the `.minio/certs` folder
Alevsk
force-pushed
the
certificates-symlinks
branch
from
September 30, 2020 02:44
d322fae
to
907a727
Compare
harshavardhana
approved these changes
Sep 30, 2020
Mint Automation
10601-33d079f/mint-gateway-azure.sh.log:
Deleting image on docker hub |
Alevsk
added a commit
to Alevsk/minio-operator
that referenced
this pull request
Sep 30, 2020
Users can define multiple certificates to be used by MinIO via the TenantSpec.ExternalCertSecret field: ``` externalCertSecret: - name: tls-test-1 type: kubernetes.io/tls - name: tls-test-2 type: kubernetes.io/tls - name: tls-test-3 type: kubernetes.io/tls ``` Will create the following folder structure inside the MinIO container: ``` certs/ │ ├─ public.crt ├─ private.key ├─ CAs/ // CAs directory is ignored │ │ │ ... │ ├─ example.com/ │ │ │ ├─ public.crt │ └─ private.key └─ foobar.org/ │ ├─ public.crt └─ private.key ... ``` This PR depends on minio/minio#10601
harshavardhana
pushed a commit
to minio/operator
that referenced
this pull request
Sep 30, 2020
Users can define multiple certificates to be used by MinIO via the TenantSpec.ExternalCertSecret field: ``` externalCertSecret: - name: tls-test-1 type: kubernetes.io/tls - name: tls-test-2 type: kubernetes.io/tls - name: tls-test-3 type: kubernetes.io/tls ``` Will create the following folder structure inside the MinIO container: ``` certs/ │ ├─ public.crt ├─ private.key ├─ CAs/ // CAs directory is ignored │ │ │ ... │ ├─ example.com/ │ │ │ ├─ public.crt │ └─ private.key └─ foobar.org/ │ ├─ public.crt └─ private.key ... ``` This PR depends on minio/minio#10601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ignore all regular files, CAs directory and any directory that starts
with
..
inside the.minio/certs
folderMotivation and Context
When minio is deployed in Kubernetes, k8s will mount TLS certificates as symlinks, ie:
By default folders to symlinks are not considered Folders by
file.isDir
(return false) soMinIO
is ignoring those certificatesHow to test this PR?
Upload certificates to your
certs
folder with the same folder structure as aboveTypes of changes
Checklist:
commit-id
orPR #
here)