Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Multiple TLS certificate in Tenant #318

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Sep 30, 2020

Users can define multiple certificates to be used by MinIO via the TenantSpec.ExternalCertSecret field:

  externalCertSecret:
    - name: tls-test-1
      type: kubernetes.io/tls
    - name: tls-test-2
      type: kubernetes.io/tls
    - name: tls-test-3
      type: kubernetes.io/tls

Will create the following folder structure inside the MinIO container:

certs/
 │
 ├─ public.crt
 ├─ private.key
 ├─ CAs/          // CAs directory is ignored
 │   │
 │    ...
 │
 ├─ example.com/
 │   │
 │   ├─ public.crt
 │   └─ private.key
 └─ foobar.org/
     │
     ├─ public.crt
     └─ private.key
   ...

This PR depends on minio/minio#10601

Users can define multiple certificates to be used by MinIO via the TenantSpec.ExternalCertSecret field:

```
  externalCertSecret:
    - name: tls-test-1
      type: kubernetes.io/tls
    - name: tls-test-2
      type: kubernetes.io/tls
    - name: tls-test-3
      type: kubernetes.io/tls
```

Will create the following folder structure inside the MinIO container:

```
certs/
 │
 ├─ public.crt
 ├─ private.key
 ├─ CAs/          // CAs directory is ignored
 │   │
 │    ...
 │
 ├─ example.com/
 │   │
 │   ├─ public.crt
 │   └─ private.key
 └─ foobar.org/
     │
     ├─ public.crt
     └─ private.key
   ...
```

This PR depends on minio/minio#10601
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

@Alevsk Alevsk requested a review from kerneltime September 30, 2020 21:28
@harshavardhana harshavardhana merged commit ab2bbdf into minio:master Sep 30, 2020
@Alevsk Alevsk deleted the minio-sni-support branch September 30, 2020 21:46
jmontleon added a commit to jmontleon/operator that referenced this pull request Jul 23, 2024
CentOS Stream 8 is EOL. For the short term we can still get packages
from the CentOS vault.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants