Include vulncheck in make #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no dependency on thirdparty actions - Get latest go version - No vulncheck in `make build`
pjuarezd
force-pushed
the
vulncheck-make
branch
from
3893b11 to
5f71001
Compare
|
Vulncheck is failing in 1.18 due to a problem with report GO-2022-0969, it's supposed to be fixed in 1.1.8.6 however the utility stills markes it as vulnerable, reported on golang/vulndb#996 Open issue in golang/go#55035 |
harshavardhana
requested changes
Sep 14, 2022
harshavardhana
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulnerability test also available in the Makefile.
One caveat is that currently there is a "vulnerability" in "net/url" package whose fix is in 1.18.6 and 1.19.1, however the DB only lists the fix in 1.19.1,
Already requested to include 1.18.6 as fixed verison
golang/vulndb#994