SDI-88: 🚨 Fix querystring warning #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergphillips
commented
May 11, 2022
server/data/hmppsAuthClient.ts
Outdated
| ) | ||
|
|
||
| return superagent | ||
| .post(`${hmppsAuthUrl}/oauth/token`) | ||
| .set('Authorization', clientToken) | ||
| .set('content-type', 'application/x-www-form-urlencoded') | ||
| .send(authRequest) | ||
| .send(new URLSearchParams(grantRequest).toString()) |
There was a problem hiding this comment.
switch to url search params instead
petergphillips
commented
May 11, 2022
| @@ -44,17 +42,17 @@ export interface UserRole { | |||
| export default class HmppsAuthClient { | |||
| constructor(private readonly tokenStore: TokenStore) {} | |||
|
|
|||
| private restClient(token: string): RestClient { | |||
| private static restClient(token: string): RestClient { | |||
There was a problem hiding this comment.
intellij suggestion as could be static
server/data/hmppsAuthClient.ts
Outdated
|
|
||
| logger.info( | ||
| `HMPPS Auth request '${authRequest}' for client id '${config.apis.hmppsAuth.systemClientId}' and user '${username}'` | ||
| `HMPPS Auth request '${grantRequest}' for client id '${config.apis.hmppsAuth.systemClientId}' and user '${username}'` |
There was a problem hiding this comment.
Not directly related I know, but maybe move grantRequest to be the first param? I think these ${} placeholders just emit 'object' or similar if it is an oject rather than a string
There was a problem hiding this comment.
also it will potentially include username twice?, or username undefined
That message is a bit weird generally
There was a problem hiding this comment.
good spot @steverendell. Now fixed to output
13:28:37.135Z INFO: grant_type=client_credentials&username=Bob HMPPS Auth request for client id 'clientid''
13:28:37.139Z INFO: grant_type=client_credentials HMPPS Auth request for client id 'clientid''
petergphillips
force-pushed
the
pgp-SDI-88-remove-querystring
branch
from
cf8094f to
6d0cb5d
Compare
tpmcgowan
added a commit
to ministryofjustice/book-a-prison-visit-staff-ui
that referenced
this pull request
May 17, 2022
psoleckimoj
pushed a commit
to ministryofjustice/book-a-prison-visit-staff-ui
that referenced
this pull request
May 18, 2022
* Fix query string warning From ministryofjustice/hmpps-template-typescript#87 * Remove stray @types/cookie-session dev dependency * Tidy up mocks and switch to multiplatform builds From ministryofjustice/hmpps-template-typescript#89 * Allow async get to take an array of path strings From ministryofjustice/hmpps-template-typescript#90 * Switch to using AppInsights connection string From ministryofjustice/hmpps-template-typescript#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.