-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade phpstan; increase phpstan level; fix a few bugs #55
base: chore/increase-phpstan-level
Are you sure you want to change the base?
Conversation
uuf6429
commented
Jan 1, 2025
•
edited
Loading
edited
-
⚠️ Must be rebased on main after Increase PHPStan level to 9 #58 is merged.
4f4011a
to
632a083
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## chore/increase-phpstan-level #55 +/- ##
==================================================================
+ Coverage 87.59% 87.74% +0.14%
+ Complexity 198 197 -1
==================================================================
Files 1 1
Lines 508 506 -2
==================================================================
- Hits 445 444 -1
+ Misses 63 62 -1 ☔ View full report in Codecov by Sentry. |
632a083
to
40df2cc
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I've mentioned in review-related commens + see my other responses in other comments:
- Upgrade phpstan; increase phpstan level; fix a few bugs #55 (comment)
- Upgrade phpstan; increase phpstan level; fix a few bugs #55 (comment)
- Upgrade phpstan; increase phpstan level; fix a few bugs #55 (comment)
.
I've made a an attempt in a different branch, but I didn't push it yet since it depends on this one and it would be too complicated to review. Since this is getting a bit complex, I suggest we organise it so:
|
cf73ed0
to
8d7197e
Compare
8d7197e
to
0d74697
Compare
0d74697
to
602aa24
Compare