Use interfaces as much as possible; switch to actions convenience class #59
Conversation
uuf6429
commented
Jan 4, 2025
•
uuf6429
commented
-
⚠️ Must be rebased on main after Upgrade phpstan; increase phpstan level; fix a few bugs #55 is merged.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
| { | ||
| $element->getLocationOnScreenOnceScrolledIntoView(); | ||
| $this->getWebDriver()->getMouse()->mouseMove($element->getCoordinates()); | ||
| $element->click(); |
There was a problem hiding this comment.
I wanted to be consistent with the other actions by using this:
$this->actions()->click($element)->perform();but for some strange reason, it does not work well in firefox, failing many tests:
https://github.com/minkphp/webdriver-classic-driver/actions/runs/12611297356/job/35146807053
I thought it might be because of the geckdriver-specific fix in RemoteWebElement->click(), but it does not seem to be the case.
My last remaining guess is that DriverCommand::CLICK_ELEMENT also waits for the page to finish loading, whereas DriverCommand::ACTIONS(W3C)/DriverCommand::CLICK(JWP) do not wait.
It may be useful to figure out exactly why, it might be the reason behind various fragile tests we have.
There was a problem hiding this comment.
You don't need to guess. Just do real-time debugging inside a WebDriver code (if you can reproduce a problem locally).
There was a problem hiding this comment.
This happens within selenium (and possibly the webbrowser). DriverCommand::CLICK_ELEMENT and DriverCommand::ACTIONS(W3C)/DriverCommand::CLICK(JWP) produce a different request to selenium. Of course I'll dig deeper..
| @@ -77,7 +83,10 @@ class WebdriverClassicDriver extends CoreDriver | |||
|
|
|||
| private const W3C_WINDOW_HANDLE_PREFIX = 'w3cwh:'; | |||
|
|
|||
| private ?RemoteWebDriver $webDriver = null; | |||
| /** | |||
| * @var TWebDriver|null | |||
There was a problem hiding this comment.
anything using phpstan type aliases should use a phpstan- prefix for @var, @param and @return to avoid issues with tools reading phpdoc without knowing about phpstan type aliases, which would treat this TWebDriver as a class name
