Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed from libsass filter, as it does not appear as a named argume… #435

Merged
merged 1 commit into from
Dec 19, 2015
Merged

removed from libsass filter, as it does not appear as a named argume… #435

merged 1 commit into from
Dec 19, 2015

Conversation

johnwheeler
Copy link
Contributor

removed image_path from libsass filter, as it does not appear as a named argument of sass.compile()

Please see function doc
http://hongminhee.org/libsass-python/sass.html#sass.compile

Getting KeyError presumably when trying to pop kwarg in sass.compile

@jezdez
Copy link

jezdez commented Dec 18, 2015

To be clear, this feature was removed upstream in libsass here following discussion here. In short: it's a compass like feature that shouldn't be in sass.

@miracle2k miracle2k merged commit f17787f into miracle2k:master Dec 19, 2015
miracle2k added a commit that referenced this pull request Dec 19, 2015
@miracle2k
"Merge pull request #435 from johnwheeler/master\n\nremoved from libs…
dab668a 
…ass filter, as it does not appear as a named argume…"
@miracle2k
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnwheeler @jezdez @miracle2k