Remove the non-standard image-url function #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 12, 2015
xzyfer
force-pushed
the
feat/remove-image-url
branch
from
cbf718f to
c82c82b
Compare
xzyfer
added a commit
that referenced
this pull request
Feb 16, 2015
Remove the non-standard image-url function
|
💯 yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the non-standard
image-urlfunction as per discussion in #489.Calling
image-urlwill now result in an error message informing the user this function no longer exists.I felt this was more developer friendly than the standard fallback of transparently outputting the function signature to css.
An alternative approach would be to produce a warning in the console and then do the normal fallback behaviour?
Thoughts @mgreter @hcatlin ?
Fixes #489. Corresponding sassc change sass/sassc#92.