Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing bounds checks for views and BE/LE #25

Closed
avsm opened this issue Jul 4, 2014 · 1 comment
Closed

Missing bounds checks for views and BE/LE #25

avsm opened this issue Jul 4, 2014 · 1 comment

Comments

@avsm
Copy link
Member

avsm commented Jul 4, 2014

See mirage/mirage-tcpip#56

The various Cstruct.LE/BE functions to do not check the validity of len of a local view, and only raise a bounds exception if the underlying Bigarray bounds are violated. We need to check the view length as well.
@avsm
Copy link
Member Author

avsm commented Jul 4, 2014

This may break existing code that worked accidentally due to not respecting the view length of Cstruct.sub results, so needs to be tested against existing users.

avsm added a commit to avsm/ocaml-cstruct that referenced this issue Jul 4, 2014
@avsm
Add failing bounds checks for views
0c15e98 
See mirage#25
This was referenced Jul 4, 2014
Merged
Closed
@avsm avsm closed this as completed in 73893f2 Jul 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avsm