Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change made to OCaml before 4.13 was branched slowed down the Windows build, but the fix (although ready for review) was deferred until during the beta cycle. The story of the fix is long and not entirely relevant, but the solution is that there is now a one-file C program in
runtime/
which forms part of the build system and so has to be built with a host ("build") C compiler. There should be an elegant solution to this in future when the OCaml tree itself natively supports cross-compilation, but in the meantime we're proposing inserting three variable hooks which ocaml-freestanding (and other cross-compiling setups) can use.This can be tested with
cc @kit-ty-kate