Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release ocaml-freestanding 0.6.5 #19655

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Sep 27, 2021

@hannesm
Copy link
Member Author

hannesm commented Sep 27, 2021

I am not sure what to do with the lower-bounds failures: any solo5-bindings* package before 0.6.5 (see Solo5/solo5#459) does not work nicely with gcc 10. Now, restricting ocaml-freestanding to solo5-bindings* >= 0.6.5 feels wrong. Marking solo5-bindings* < 0.6.5 as not available also feels wrong.

A good solution would be to depend in solo5-bindings* on "if gcc is used as cc, then require gcc < 10", but I suspect this is hard in opam.

On the other hand, already having spend 5 minutes on this, I would be fine to mark these old solo5 packages as unavailable. Development is moving forward, no need to support and spend time on arcane versions that are unlikely being used by anyone.

What do you think (esp. @mseri @kit-ty-kate)?

@hannesm
Copy link
Member Author

hannesm commented Sep 27, 2021

see #19656 as my proposal on this topic.

@hannesm
Copy link
Member Author

hannesm commented Sep 27, 2021

I looked through the failures, they are unrelated to this release. The only action item are the solo5-bindings-* lower bounds (gcc), as outlined in the above comment, and being addressed in a separate PR.

@hannesm
Copy link
Member Author

hannesm commented Oct 4, 2021

is there anything I can do to move forward with this PR?

@mseri
Copy link
Member

mseri commented Oct 4, 2021

In this case, I think we should just let the lower bound check to fail. Once it will be possible to encode:

A good solution would be to depend in solo5-bindings* on "if gcc is used as cc, then require gcc < 10", but I suspect this is hard in opam.

we can think of doing that

@mseri
Copy link
Member

mseri commented Oct 4, 2021

I just came back from holiday and Kate is also in holiday, it will take some time before we restart merging at the usual pace

@mseri mseri merged commit 3fd503d into ocaml:master Oct 4, 2021
@hannesm hannesm deleted the ocaml-freestanding.0.6.5 branch October 4, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants