Adds Multiball Ball Save for Add A Ball #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a unique ball save feature for add a ball. This uses the same event calls, so you can trigger your shows off the same events for normal ball save and add a ball ball save. The add a ball ball save will not run (or add time) if the ball save is already running. But if the normal ball save has expired, it will start this ball save at the add a ball configured times for shoot again, hurry up, and grace period.
jabdoa2
reviewed
Aug 10, 2021
jabdoa2
reviewed
Aug 10, 2021
jabdoa2
reviewed
Aug 10, 2021
|
Quite a nice addition. I love it! Left some small nits. |
Adds a method to handle the callbacks for ball save end, hurry up, and grace period. This is used by normal ball save and add a ball ball save.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unique ball save feature for add a ball. This uses the same
event calls, so you can trigger your shows off the same events for
normal ball save and add a ball ball save. The add a ball ball save
will not run (or add time) if the ball save is already running. But if
the normal ball save has expired, it will start this ball save at the
add a ball configured times for shoot again, hurry up, and grace period.