Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email verify enable logic #12743

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

Candinya
Copy link
Contributor

What

Why

meta.verifymailAuthKey -> affects verifymailApi -> already handled above
meta.enableActiveEmailValidation -> affects whether enable email verify logic -> already handled in if situations

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f88ed4d) 81.91% compared to head (40d0cf8) 79.77%.
Report is 3 commits behind head on develop.

Files Patch % Lines
packages/backend/src/core/EmailService.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12743      +/-   ##
===========================================
- Coverage    81.91%   79.77%   -2.14%     
===========================================
  Files          180      956     +776     
  Lines        27475   108745   +81270     
  Branches       511     8368    +7857     
===========================================
+ Hits         22505    86749   +64244     
- Misses        4970    21996   +17026     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mar0xy
Copy link
Contributor

Mar0xy commented Dec 22, 2023

I feel like this should be merged for #12564 as this fixes an issue where having validation enabled but no key for verifymail set causing it to not run the else statement to check via the node package instead as it just skips everything else and always defaults to valid.

@syuilo syuilo merged commit b3c4f7e into misskey-dev:develop Dec 23, 2023
15 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 23, 2023

🙏

@Candinya Candinya deleted the fix/email-verify-enable-logic branch December 23, 2023 03:01
@syuilo
Copy link
Member

syuilo commented Dec 23, 2023

lintが失敗してそう

@Candinya Candinya mentioned this pull request Dec 23, 2023
5 tasks
@Candinya
Copy link
Contributor Author

lintが失敗してそう

should be fixed in #12761

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants