Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lint #12743 #12761

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fix: lint #12743 #12761

merged 1 commit into from
Dec 24, 2023

Conversation

Candinya
Copy link
Contributor

What

fix: lint fail caused by #12743

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Dec 23, 2023
@Candinya Candinya changed the title fix: lint fix: lint #12743 Dec 23, 2023
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (471c8ec) 79.79% compared to head (ccf5774) 79.90%.

Files Patch % Lines
packages/backend/src/core/EmailService.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12761      +/-   ##
===========================================
+ Coverage    79.79%   79.90%   +0.10%     
===========================================
  Files          956      956              
  Lines       108800   108802       +2     
  Branches      8373     8405      +32     
===========================================
+ Hits         86814    86934     +120     
+ Misses       21986    21868     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Candinya Candinya marked this pull request as ready for review December 23, 2023 13:04
@Candinya Candinya mentioned this pull request Dec 23, 2023
5 tasks
@syuilo syuilo merged commit cae40e6 into misskey-dev:develop Dec 24, 2023
16 of 18 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 24, 2023

🙏🏻

@Candinya Candinya deleted the fix/email-service-lint branch December 24, 2023 10:27
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
madonuko pushed a commit to FyraLabs/nyaakey that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants