fix(frontend): カスタム絵文字が削除されている場合は絵文字ピッカーに表示しないように #13508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13508 +/- ##
===========================================
- Coverage 79.95% 77.66% -2.30%
===========================================
Files 956 185 -771
Lines 108864 24996 -83868
Branches 8413 481 -7932
===========================================
- Hits 87045 19412 -67633
+ Misses 21819 5577 -16242
- Partials 0 7 +7 ☔ View full report in Codecov by Sentry. |
samunohito
reviewed
Mar 4, 2024
| @@ -152,10 +152,10 @@ const { | |||
| } = defaultStore.reactiveState; | |||
|
|
|||
| const recentlyUsedEmojisDef = computed(() => { | |||
| return recentlyUsedEmojis.value.map(getDef); | |||
| return recentlyUsedEmojis.value.map(getDef).filter(x => x != null);; | |||
There was a problem hiding this comment.
getDefの実装によりnullが返ることはなくなっているので、この実装を単純に取り込むのみでは対応できないかと思います。
There was a problem hiding this comment.
動作的には治っていそうなのでこれ自体Closeしてもいいかもしれない
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Cherry-picked from https://activitypub.software/TransFem-org/Sharkey/-/commit/687035c5ca826b0606678325f3ee975f396fa79c
存在しないカスタム絵文字は絵文字ピッカーで選択できないようにする
Why
Additional info (optional)
Checklist