Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): カスタム絵文字が削除されている場合は絵文字ピッカーに表示しないように #13508

Closed
wants to merge 1 commit into from
Closed

fix(frontend): カスタム絵文字が削除されている場合は絵文字ピッカーに表示しないように #13508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/frontend/src/components/MkEmojiPicker.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,10 @@
} = defaultStore.reactiveState;

const recentlyUsedEmojisDef = computed(() => {
return recentlyUsedEmojis.value.map(getDef);
return recentlyUsedEmojis.value.map(getDef).filter(x => x != null);;

Check failure on line 155 in packages/frontend/src/components/MkEmojiPicker.vue

View workflow job for this annotation

GitHub Actions / lint (frontend) 

Missing whitespace after semicolon

Check failure on line 155 in packages/frontend/src/components/MkEmojiPicker.vue

View workflow job for this annotation

GitHub Actions / lint (frontend) 

Unnecessary semicolon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDefの実装によりnullが返ることはなくなっているので、この実装を単純に取り込むのみでは対応できないかと思います。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13486

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作的には治っていそうなのでこれ自体Closeしてもいいかもしれない

});
const pinnedEmojisDef = computed(() => {
return pinned.value?.map(getDef);
return pinned.value?.map(getDef).filter(x => x != null);;

Check failure on line 158 in packages/frontend/src/components/MkEmojiPicker.vue

View workflow job for this annotation

GitHub Actions / lint (frontend) 

Missing whitespace after semicolon

Check failure on line 158 in packages/frontend/src/components/MkEmojiPicker.vue

View workflow job for this annotation

GitHub Actions / lint (frontend) 

Unnecessary semicolon
});

const pinned = computed(() => props.pinnedEmojis);
Expand Down
Loading