Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 投稿フォームでEscキーが押されたときIME入力中ならダイアログは閉じない #14787

Merged

Conversation

yuba
Copy link
Contributor

@yuba yuba commented Oct 19, 2024

What

投稿フォームMkPostFormの入力エリア(通常入力エリアとCW入力エリア)でEscキーが押されたとき、
IME変換セッション中ならばフォームを閉じないようにします。

#10866 を実現します。

Why

打ち込みかけの日本語入力をEscキーで解除する操作はよくありますが、
それでダイアログまで閉じてしまうのはユーザーの意図ではないため。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 19, 2024
@yuba yuba changed the title refs#10866 投稿ダイアログでEscキーが押されたときIME入力中ならダイアログは閉じない enhance(frontend): 投稿フォームでEscキーが押されたときIME入力中ならダイアログは閉じない Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.34%. Comparing base (bc0c53b) to head (18da063).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14787      +/-   ##
===========================================
- Coverage    19.52%   19.34%   -0.18%     
===========================================
  Files          722      722              
  Lines       102507   102515       +8     
  Branches       990      992       +2     
===========================================
- Hits         20015    19833     -182     
- Misses       81943    82131     +188     
- Partials       549      551       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuba yuba force-pushed the feature/10866_ignore_esc_key_when_composing branch from 711f90a to 687ec25 Compare October 20, 2024 13:00
@yuba yuba force-pushed the feature/10866_ignore_esc_key_when_composing branch from 687ec25 to 50dc725 Compare October 20, 2024 13:02
@yuba
Copy link
Contributor Author

yuba commented Oct 20, 2024

resolved confliction.

@syuilo syuilo merged commit 2f9c04b into misskey-dev:develop Oct 21, 2024
22 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 21, 2024

🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
3 participants