Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 外部アプリ認証画面の改良 #14828

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 24, 2024

What

  • 端末に存在するどのアカウントでも認証できるように
  • 認証画面でどのアカウントで認証しようとしているのか確認できるように

image

image

Why

Fix #14827

Additional info (optional)

アプリ認証は処理がMiAuth/OAuthと全く違う+既に非推奨扱いなので改修対象外

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 1.33531% with 665 lines in your changes missing coverage. Please review.

Project coverage is 19.21%. Comparing base (15ae160) to head (e867b4c).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkAuthConfirm.vue 0.00% 449 Missing and 1 partial ⚠️
packages/frontend/src/pages/miauth.vue 0.00% 76 Missing ⚠️
packages/frontend/src/pages/oauth.vue 0.00% 71 Missing ⚠️
packages/frontend/src/account.ts 8.33% 44 Missing ⚠️
...ackages/frontend/src/components/MkSignupDialog.vue 0.00% 8 Missing ⚠️
packages/frontend/src/pages/settings/accounts.vue 0.00% 8 Missing ⚠️
...ntend/src/components/MkAuthConfirm.stories.impl.ts 0.00% 6 Missing and 1 partial ⚠️
packages/frontend/src/_boot_.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14828       +/-   ##
============================================
- Coverage    39.65%   19.21%   -20.44%     
============================================
  Files         1555      724      -831     
  Lines       196110   103222    -92888     
  Branches      3636      994     -2642     
============================================
- Hits         77765    19836    -57929     
+ Misses      117743    82833    -34910     
+ Partials       602      553       -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 24, 2024 10:49
@syuilo syuilo merged commit 076cc95 into misskey-dev:develop Oct 25, 2024
22 of 23 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 25, 2024

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the enh-14827 branch October 25, 2024 05:34
kakkokari-gtyih added a commit that referenced this pull request Oct 25, 2024
#14828 のデザイン修正
SWREI pushed a commit to hotomoe/hotomoe that referenced this pull request Oct 28, 2024
misskey-dev#14828 のデザイン修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miAuth認証画面で認証するアカウントを明示的にしてほしい
2 participants