Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): アンケート(投票)でリモートの絵文字が正しく描画できない問題の修正 #15306

Merged
merged 3 commits into from
Jan 19, 2025

Conversation

tai-cha
Copy link
Contributor

@tai-cha tai-cha commented Jan 18, 2025

What

authorおよびemojiUrlをMkPollに渡せるように
(Cherry-picked from yojo-art/cherrypick#153)

Why

Fix #11763

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 18, 2025
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 19.98%. Comparing base (1ef62e9) to head (7f7d76f).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNoteDetailed.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15306       +/-   ##
============================================
- Coverage    40.47%   19.98%   -20.49%     
============================================
  Files         1568      731      -837     
  Lines       199140   104492    -94648     
  Branches      3955     1200     -2755     
============================================
- Hits         80592    20886    -59706     
+ Misses      117943    83052    -34891     
+ Partials       605      554       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mi-gh-maintainer mi-gh-maintainer bot merged commit 078b7d6 into misskey-dev:develop Jan 19, 2025
22 checks passed
Copy link

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

リモート投票の選択肢に入っているカスタム絵文字がローカル準拠になる
4 participants