Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アンケート選択肢にリモート絵文字を表示 #153

Merged
merged 2 commits into from
Jul 6, 2024

Conversation

kozakura913
Copy link
Collaborator

@kozakura913 kozakura913 commented Jul 5, 2024

close: #150

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG_CHERRYPICK.md
  • (If possible) Add tests

@kozakura913 kozakura913 requested review from penginn-net and jj1guj July 5, 2024 08:41
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (b8dfb6e) to head (876ecc4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
- Coverage    78.36%   78.19%   -0.17%     
===========================================
  Files          196      194       -2     
  Lines        29348    29126     -222     
  Branches       474      474              
===========================================
- Hits         22998    22776     -222     
  Misses        6344     6344              
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@penginn-net penginn-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: アンケート選択肢にリモート絵文字を表示

リモートノートのアンケート選択肢に絵文字が含まれる場合ローカル基準になってる
とかがいいかも

@kozakura913
Copy link
Collaborator Author

kozakura913 commented Jul 6, 2024

「アンケート選択肢が必ずローカル基準になる」とかも検討したけどこれがわかりやすいかなって

@penginn-net
Copy link
Collaborator

なるほど

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

リモートのアンケートに含まれる絵文字がローカルの物になる
2 participants