Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: api/notifications/readは配列でも受け付けるように #7605

Closed
wants to merge 45 commits into from

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented Jul 17, 2021

Summary

Resolve #6413

#7129 ではnotifications/readを大量に発行する場面があるため、通信量やサーバー不可を削減したいので配列で受け付けるように

@tamaina tamaina mentioned this pull request Jul 17, 2021
8 tasks
@tamaina tamaina changed the title api/notifications/readは配列で受け付けるように enhance: api/notifications/readは配列でも受け付けるように Jul 26, 2021
@tamaina tamaina mentioned this pull request Aug 19, 2021
9 tasks
@rinsuki
Copy link
Contributor

rinsuki commented Aug 19, 2021

conflictしてる

@tamaina
Copy link
Contributor Author

tamaina commented Aug 19, 2021

なおした

@tamaina
Copy link
Contributor Author

tamaina commented Nov 11, 2021

エラー出ないようにした

@tamaina
Copy link
Contributor Author

tamaina commented Feb 19, 2022

プロパティ(ajv)スキーマって{ type: 'object'; properties: Record<string, Schema>}が突っ込まれるの前提なんかな

(それだとoneOfで書くとまずそう)

@tamaina
Copy link
Contributor Author

tamaina commented May 1, 2022

#7667 includes this change

@tamaina tamaina closed this May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

特定の通知を既読にするエンドポイント(notifications/read)
4 participants