-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Push Notification #7667
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexedDBが何かの拍子に壊れるっぽくて頭を抱えている |
mark-all-as-read叩いてもインジケータが消えない |
直した
再現性がないのでとりあえずパス |
直ってないんじゃないかな |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #6359, Resolve #6628, Resolve #6395
#7129 でgitの誤操作によりブランチが蒸発したため新規にPRを出します。
かなり長期間にわたっていますので、#7129も参照してください。
What
Service Workerのプッシュ通知を拡張し、actionsを用いて通知に反応できるようにします。
また、プッシュ通知まわりの挙動の整理もします。
Why
Service Workerのプッシュ通知でいろいろできるので
依存PR
Waiting to merge
#7605,
Merged
#7108, #7196, #7609, #7611, #7750, #7606, #7928, #7929
Changes
バグ(仕様です)
プッシュ通知のペイロードが長すぎるとブラウザのプッシュ通知エンドポイントへ送信する際にエラーとなる将来的な拡張(今回のPRでは行わない)