Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsInSimulation() is being set too early #102

Closed
neico opened this issue Sep 9, 2022 · 0 comments · Fixed by #191
Closed

IsInSimulation() is being set too early #102

neico opened this issue Sep 9, 2022 · 0 comments · Fixed by #191

Comments

@neico
Copy link

neico commented Sep 9, 2022

m_bSimulating is being set to true too early in JoltPhysicsEnvironment::Simulate, it needs to be at least after PostSimulationFrame,
otherwise you're causing an assert message here for every frame in debug builds

I don't expect this to change much beyond silencing the console spam, but with this engine you never know...
@RaphaelIT7 RaphaelIT7 mentioned this issue Oct 1, 2023
Closed
RaphaelIT7 added a commit to RaphaelIT7/VPhysics-Jolt that referenced this issue Oct 1, 2023
@RaphaelIT7
Fixed IsInSimulation() is being set too early
9fe86c1 
Related issue:
fixes misyltoad#102
@RaphaelIT7 RaphaelIT7 mentioned this issue Oct 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@neico