Enable easy-to-run test-controller-style benchmarks locally #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalosGhost
force-pushed
the
feat/easy-run-system
branch
from
5225544 to
d8020eb
Compare
maurermi
requested changes
Apr 25, 2024
There was a problem hiding this comment.
Mostly looks good to me, suggested a couple changes but I very much welcome this addition.
One additional question, would it be possible to alert the user, or terminate the test if a component dies during the test? I think that could be quite useful especially for long running tests.
Includes: * executes outside docker, creating a single process per-component * takes a config file and executes accordingly * automatically generates some graphs for the run * supports running all components under debuggers/valgrind/perf * creates and caches preseeds as-specified * preserves benchmark artifacts out-of-tree Co-authored-by: Michael Maurer <maurer.mi@northeastern.edu> Signed-off-by: Sam Stuewe <stuewe@mit.edu>
HalosGhost
force-pushed
the
feat/easy-run-system
branch
from
d8020eb to
2673991
Compare
maurermi
approved these changes
May 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP script that allows you to take a crafted configuration file (including one generated by the test controller), and execute a benchmark against that configuration using one process-per-component.
Needed before merging:
<commit_hash,preseed_count,shard_count>triple for uniqueness)