change default ports #289
Merged
change default ports #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like there are a In particular, the |
|
@HalosGhost Yep - I can go through the other tests and make those changes |
maurermi
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
T-ACK. This is useful when running on my local system since port 5000 is often occupied. I approve of these changes but second @HalosGhost 's comment that this should be replicated elsewhere in the code.
Signed-off-by: eolesinski <eo2454@columbia.edu>
eolesinski
force-pushed
the
port-changes
branch
from
21bc02e to
a6c9818
Compare
maurermi
approved these changes
Aug 6, 2024
HalosGhost
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
T-ACK. Just swaps out the default ports we use to something less crowded. Hopefully defaults to causing far fewer headaches!
Thanks @eolesinski
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #97 by updating the port numbers used in the
raft_test.cppunit tests to a higher range (29800-29802) to avoid conflicts with commonly used ports.Port conflicts with 5000 are frequent, especially with the docker-registry and Apple's AirPlay Receiver on MacOS. To address this issue, the default ports are updated to 298xx, following the convention outlined in #259.
Tested: tested by running
./scripts/test.shEDIT: This change now updates all test endpoints that use ports at 5xxx