Merge pull request #429 from mitre-attack/fix/#326-handle-empty-tacti…

…c-names

Added catch and warning alert if user uploads layer with an empty tactic field

CHANGELOG.md

@@ -15,6 +15,7 @@
 
 - Fixed a versioning error that occurred when loading a local layer with a previous version of ATT&CK.
 - Added a feature to pin a technique cell when viewed in the matrix, enabling the user to scroll the details of the technique in the tooltip. See issue [#320](https://github.com/mitre-attack/attack-navigator/issues/320).
+- Added a popup alert to notify users if a layer with an empty tactic field is uploaded, and therefore will not be displayed. See issue [#326](https://github.com/mitre-attack/attack-navigator/issues/326).
 
 # v4.6.0 - 25 April 2022
 

nav-app/src/app/viewmodels.service.ts

@@ -1653,8 +1653,11 @@ export class TechniqueVM {
         if (techniqueID !== undefined) this.techniqueID = techniqueID;
         else console.error("ERROR: TechniqueID field not present in technique")
 
-        if ("tactic" !== undefined) this.tactic = tactic;
-        else console.error("ERROR: tactic field not present in technique")
+        if (tactic !== undefined && tactic !== "") this.tactic = tactic;
+        else {
+            console.error("WARNING: tactic field not present in technique");
+            alert(`WARNING: The tactic field on the technique ID ${techniqueID} is not defined. Annotations for this technique will not be restored.`);
+        }
         if ("comment" in obj) {
             if (typeof(obj.comment) === "string") this.comment = obj.comment;
             else console.error("TypeError: technique comment field is not a number:", obj.comment, "(",typeof(obj.comment),")")