Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading a technique with an empty tactic ("") should either ignore the value or reject the layer #326

Closed
isaisabel opened this issue Jul 29, 2021 · 0 comments · Fixed by #429
Assignees
Labels
bug Something isn't working enhancement New feature or request Points: 1 1 agile story point timescale/short-term Becomes timescale/imminent in weeks or months
Milestone

Comments

@isaisabel
Copy link
Contributor

As a user, I want the Navigator to catch improperly formatted layers.

Currently, uploading a layer with the following technique:

{
    "techniqueID": "T1001",
    "color": "#66ffaa",
    "tactic": "",
    "comment": "example comment",
    "enabled": true,
    "metadata": [],
    "showSubtechniques": false
}

Will not show the annotation because the tactic is matched to "". Since there are no tactics with an empty shortname this will essentially hide the annotation.

The Navigator should either:

  • Treat "" tactic values as if they are undefined and map the annotation across tactics, or:
  • Treat an empty string as an invalid value, and reject the layer from the upload

The current result, while adhering to the layer schema, is very hard to debug since it's easy to assume that an empty tactic string is the same as omitting the tactic field altogether.

@isaisabel isaisabel added bug Something isn't working enhancement New feature or request timescale/short-term Becomes timescale/imminent in weeks or months Points: 1 1 agile story point labels Jul 29, 2021
@isaisabel isaisabel added this to the Version 4.5.2 milestone Oct 22, 2021
@iguannalin iguannalin self-assigned this Apr 26, 2022
iguannalin added a commit that referenced this issue Apr 26, 2022
iguannalin added a commit that referenced this issue Apr 28, 2022
clemiller added a commit that referenced this issue Apr 29, 2022
…c-names

Added catch and warning alert if user uploads layer with an empty tactic field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Points: 1 1 agile story point timescale/short-term Becomes timescale/imminent in weeks or months
Projects
None yet
3 participants