Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by highest score appears to be broken #295

Closed
beerMT opened this issue May 12, 2021 · 4 comments · Fixed by #305
Closed

Sort by highest score appears to be broken #295

beerMT opened this issue May 12, 2021 · 4 comments · Fixed by #305
Labels
bug Something isn't working
Milestone

Comments

@beerMT
Copy link

beerMT commented May 12, 2021

I love the roll-up (sum) of SubTechniques into the Techniques score, thanks for that update!

When sorting by most frequently occurring Technique, the following was the result:
sorted_butNot

I have "hotter" red items that did not bubble up. Any help here on regaining that functionality would be great.

Cheers,
Brad

@isaisabel
Copy link
Contributor

Hi @beerMT,

Is there any chance you can upload the layer you're using so that we can use it to debug? I'm having a bit of trouble reproducing the issue.

@isaisabel isaisabel added the bug Something isn't working label May 17, 2021
@beerMT
Copy link
Author

beerMT commented May 17, 2021

Thanks for taking a look. I have attached a test merged layer, which consists of roughly 33 TA's merged together that target a test industry. The Techniques/Subtechniques were added together/incremented if present in the jsons. This was the layer that produced the output heatmap for opening the issue.

merged_test.json.zip

@iguannalin
Copy link
Contributor

iguannalin commented May 26, 2021

Hi @beerMT,

Thanks for sharing that json file. You're right, I see that the colors are being calculated correctly, but it does not seem to be sorting by the aggregate score correctly when that's enabled. We should fix this as an issue.

@isaisabel isaisabel added this to the Version 4.4 milestone May 26, 2021
@iguannalin iguannalin linked a pull request Jun 10, 2021 that will close this issue
isaisabel added a commit that referenced this issue Jun 24, 2021
…-aggregate-score

Fix/#295 sort techniques by aggregate score
@isaisabel
Copy link
Contributor

This issue is now fixed on develop and will be released with Navigator v4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants