Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/#295 sort techniques by aggregate score #305

Merged
merged 10 commits into from
Jun 24, 2021
Merged

Fix/#295 sort techniques by aggregate score #305

merged 10 commits into from
Jun 24, 2021

Conversation

iguannalin
Copy link
Contributor

Fixed issue #295, example JSON file to test can be found in thread.

@iguannalin iguannalin self-assigned this Jun 10, 2021
@iguannalin iguannalin linked an issue Jun 10, 2021 that may be closed by this pull request
Sort by highest score appears to be broken #295
Closed
@iguannalin
Fixed errors with parsing booleans from object values (values were re…
134f0b4 
…turning typeof string, throwing a TypeError)
@iguannalin iguannalin requested a review from isaisabel June 11, 2021 19:29
@isaisabel
Copy link
Contributor

This supersedes #304, right? They look mostly identical.

@iguannalin
Copy link
Contributor Author

iguannalin commented Jun 14, 2021 •
edited
Loading

@isaisabel Yeah, I accidentally clicked the button twice and it created two identical PRs, that's why I closed #304

isaisabel
isaisabel reviewed Jun 23, 2021
View reviewed changes
Copy link
Contributor

@isaisabel isaisabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely resolves the bug, but I'm curious about one of the additions that seems unrelated.

nav-app/src/app/viewmodels.service.ts Outdated Show resolved Hide resolved
@iguannalin iguannalin requested a review from isaisabel June 23, 2021 18:36
isaisabel
isaisabel suggested changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@isaisabel isaisabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, realize I already approved it but I just noticed there is no changelog entry for this. Aside from that it's all set!

@iguannalin iguannalin requested a review from isaisabel June 23, 2021 20:40
@isaisabel isaisabel merged commit b3b8696 into develop Jun 24, 2021
@clemiller clemiller deleted the fix/#295-sort-techniques-by-aggregate-score branch February 17, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaisabel isaisabel isaisabel approved these changes

Assignees

@iguannalin iguannalin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort by highest score appears to be broken
2 participants
@iguannalin @isaisabel