Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ground truths in test-tune.spca() #277

Closed
Max-Bladen opened this issue Dec 8, 2022 · 0 comments · Fixed by #278
Closed

Incorrect ground truths in test-tune.spca() #277

Max-Bladen opened this issue Dec 8, 2022 · 0 comments · Fixed by #278
Assignees
Labels
bug Something isn't working

Comments

@Max-Bladen
Copy link
Collaborator

🐞 Describe the bug:
Errors raised in R-CMD-check. Very annoying as the values produced when these tests are run locally differ from those run via GitHub actions


🔍 reprex results from reproducible example including sessioninfo():

══ Failed tests ════════════════════════════════════════════════════════════════
── Failure ('test-tune.spca.R:15'): tune.spca works ────────────────────────────
object$choice.keepX[[1]] not equal to 25.
1/1 mismatches
[1] 35 - 25 == 10
── Failure ('test-tune.spca.R:16'): tune.spca works ────────────────────────────
object$choice.keepX[[2]] not equal to 35.
1/1 mismatches
[1] 15 - 35 == -20
── Failure ('test-tune.spca.R:41'): tune.spca works with NA input ──────────────
object$choice.keepX[[2]] not equal to 25.
1/1 mismatches
[1] 15 - 25 == -10

🤔 Expected behavior:
No errors should be raised


💡 Possible solution:
Either adjust and control RNG or reduce values checked against (latter is temporary fix)

@Max-Bladen Max-Bladen added bug Something isn't working wip work-in-progress labels Dec 8, 2022
@Max-Bladen Max-Bladen self-assigned this Dec 8, 2022
Max-Bladen added a commit that referenced this issue Dec 8, 2022
test: removed some `expect_equal()` states from `test-tune.spca()` as they were producing inconsistent values locally vs via GitHub Actions
@Max-Bladen Max-Bladen linked a pull request Dec 8, 2022 that will close this issue
Max-Bladen added a commit that referenced this issue Dec 8, 2022
test: removed some `expect_equal()` states from `test-tune.spca()` as they were producing inconsistent values locally vs via GitHub Actions
@Max-Bladen Max-Bladen removed the wip work-in-progress label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant