PR addressing Issue #24 #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-Bladen
added
the
ready-to-review
Max-Bladen
added
enhancement-implementation
enhance: adding the functionality required in `plotIndiv.mint.pls()` in order to handle and use output from `background.predict()`. Involves adding parameter and correctly adjusting limits of plot to accommodate polygons
enhance: moved the definitions of global attributes `scaled:center` and `scaled:scale` out of `else` statement prevent it's usage
fix: adjust minor error in f81cacf. extremes of background polygons is now correctly calculated
enhance: copied code segment used by this function and added it to `style == "ggplot2-MINT"`
docs: SemVer updated and `plotIndiv()` documentation updated
test: add test for `plotIndiv` on MINT object with background. maintains coverage
|
Second set of commits on 13/12/2022 reflect initial set of commits, but replicated after the branch was rebased to master following PR #281. |
Max-Bladen
removed
the
ready-to-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derives from closed and depreciated PR (#198).
Mostly the same implementation, such that:
plotIndiv.mint.pls()given functionality to processbackground.predictobjects. Included adjusting way in which X and Y axes limits are calculated to ensure polygons showmean_centering_per_study()adjusted to add the globalscaled:centerandscaled:scaleattributes to output.internal_graphicModule()had theif (style == "ggplot2-MINT")updated to include background polygons inplotIndiv()figures.Commits and commit messages were redone too.