Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR addressing Issue #24 #226

Merged
merged 6 commits into from
Dec 13, 2022
Merged

PR addressing Issue #24 #226

merged 6 commits into from
Dec 13, 2022

Commits on Dec 13, 2022

  1. background for plotIndiv.mint.pls() 

    enhance: adding the functionality required in `plotIndiv.mint.pls()` in order to handle and use output from `background.predict()`.

Involves adding parameter and correctly adjusting limits of plot to accommodate polygons
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1803511 View commit details
    Browse the repository at this point in the history

  2. ensure required attributes are defined 

    enhance: moved the definitions of global attributes `scaled:center` and `scaled:scale` out of `else` statement prevent it's usage
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c710e9b View commit details
    Browse the repository at this point in the history

  3. adjust limit definition 

    fix: adjust minor error in f81cacf. extremes of background polygons is now correctly calculated
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c8c62f5 View commit details
    Browse the repository at this point in the history

  4. background in internal_graphicModule() 

    enhance: copied code segment used by this function and added it to `style == "ggplot2-MINT"`
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0ab7aaf View commit details
    Browse the repository at this point in the history

  5. updated documentation 

    docs: SemVer updated and `plotIndiv()` documentation updated
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6a51030 View commit details
    Browse the repository at this point in the history

  6. added test 

    test: add test for `plotIndiv` on MINT object with background. maintains coverage
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0cf7016 View commit details
    Browse the repository at this point in the history