PR addressing Issue #248 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-Bladen
added
rapid-review
Max-Bladen
added
enhancement-implementation
Max-Bladen
changed the title
Max-Bladen
changed the title
refactor: added aliases for circosPlot to take `block.pls` and `block.plsda` objects
fix: changed object class check
fix: adjusted first check in `circosPlot()`. Needs to apply changes to any DA object otherwise there are downstream errors. Errors were caused by mismatch of length between `X` and `object$variates`
docs: updated `circosPlot()` docs with changed to `object` parameter
Max-Bladen
force-pushed
the
issue-248
branch
from
0306510
to
67de24b
Compare
|
Second set of commits on 13/12/2022 reflect initial set of commits, but replicated after the branch was rebased to master following PR #281. |
Max-Bladen
removed
rapid-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple PR to bring the functionality of
circosPlot()to all block objects. Previously, it could only be suppliedblock.spls(da)objects. Now this also includesblock.pls(da)objects (ie. non-sparse block methods)