Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR addressing Issue #248 #249

Merged
merged 5 commits into from
Dec 13, 2022
Merged

PR addressing Issue #248 #249

merged 5 commits into from
Dec 13, 2022

Commits on Dec 13, 2022

  1. Fix for Issue #248 

    refactor: added aliases for circosPlot to take `block.pls` and `block.plsda` objects
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8835d34 View commit details
    Browse the repository at this point in the history

  2. Fix for Issue #248 

    fix: changed object class check
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f4d7fac View commit details
    Browse the repository at this point in the history

  3. Fix for Issue #248 

    fix: adjusted first check in `circosPlot()`. Needs to apply changes to any DA object otherwise there are downstream errors.

Errors were caused by mismatch of length between `X` and `object$variates`
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    589065f View commit details
    Browse the repository at this point in the history

  4. Fix for Issue #248 

    docs: updated `circosPlot()` docs with changed to `object` parameter
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    67de24b View commit details
    Browse the repository at this point in the history

  5. Issue #248 solution 

    docs: needed to compile documentation to synchronise `circosPlot` parameters
    @Max-Bladen
    Max-Bladen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    edd63ae View commit details
    Browse the repository at this point in the history