Return a local copy of m_cuePoints to avaoid a race consition

mixxxdj · Oct 18, 2022 · 6712c19 · 6712c19
1 parent a4c9cab
commit 6712c19
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/control/control.h b/src/control/control.h
@@ -64,8 +64,9 @@ class ControlDoublePrivate : public QObject {
     static QList<QSharedPointer<ControlDoublePrivate>> takeAllInstances();
 
     static QHash<ConfigKey, ConfigKey> getControlAliases() {
-        // Implicitly shared classes can safely be copied across threads
-        return s_qCOAliasHash;
+        MMutexLocker locker(&s_qCOHashMutex);
+        QHash<ConfigKey, ConfigKey> controlAliases = s_qCOAliasHash;
+        return controlAliases;
     }
 
     const QString& name() const {