Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest vcpkg environment #11074

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Nov 16, 2022

This updates a bunch of libraries for Windows and macOS:

  • harfbuzz 5.0.1 (from 04.02.0)
  • libjpeg-turbo 2.1.4 (from 2.1.3)
  • libusb 2.0.4 (from 1.0.24)
  • libwebp 1.2.4 (from 01.02.02)
  • openssl 3.0.7 (form 3.0.3)
  • protobuf 3.21.8 (from 3.19.4)
  • Windows only: qt5 5.15.7 (from 5.15.6)
  • rubberband 3.1.1 (from 3.0.0)
  • sqlite3 3.39.2 (from 3.37.2)
  • wavpack 5.5.0 (from 5.4.0)
  • zlib 1.2.13 (from 1.2.12)

Before merge we need some manual smoke testes.

@JoergAtGithub
Copy link
Member

I tested both the latest Main and this PR on my old Laptop with Windows7 and VS2019 and my new laptop with Windows11 and VS2022. I built x64_portable on both.

Win7 + VS2019
Builds succeeded
Tests 100% Pass
Short test of Mixxx with controller and ASIO looked good

Win10 + VS2022
Builds succeeded
With both buildenvs (old and new) 4 SoundSourceProxyTests fail - see #11094
Short test of Mixxx with controller and ASIO looked good
-Waveforms feel a bit smoother with the new buildenv - less drop-outs at 60fps

@JoergAtGithub
Copy link
Member

@ronso0 ronso0 added this to the 2.4.0 milestone Dec 4, 2022
@daschuer
Copy link
Member Author

daschuer commented Jan 3, 2023

Conclusion form the MacOS test by @m0dB: No regressions

for me it runs on par as the current buildenv.

Can one merge this?

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusting @m0dB here

@Swiftb0y Swiftb0y merged commit eeca692 into mixxxdj:main Jan 3, 2023
@daschuer
Copy link
Member Author

daschuer commented Jan 3, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants