Fix Serato Metadata checkbox behaviour #11441
Conversation
|
Closing PRs with unresolved review comments and opening new PRs instead is not helpful. |
|
You need to start from the 2.4 branch to avoid rebasing. |
I know but sometimes it becomes quite messy, so I think of it as a fresh start. Sorry, will keep that mind for the future PRs. |
Alright, so I need to change the base branch of this PR and rebase it? |
This comment was marked as spam.
This comment was marked as spam.
I need to merge this commit onto a branch, @JoergAtGithub told me that its a 2.3 patch so initially I requested for 2.3 branch but now @daschuer wants 2.4 branch to be the base so I did the changes, but now I am not sure what to do next! I followed this. |
|
@JoergAtGithub is correct, this is a patch that can go to 2.3. |
|
You did your work however on the main branch. This will do the trick: |
This comment was marked as spam.
This comment was marked as spam.
| @@ -554,4 +555,6 @@ void DlgPrefLibrary::slotSyncTrackMetadataToggled() { | |||
| if (isVisible() && checkBox_SyncTrackMetadata->isChecked()) { | |||
| mixxx::DlgTrackMetadataExport::showMessageBoxOncePerSession(); | |||
| } | |||
| // If Track Metatdata checkbox is unchecked, ignore the state of Serato Metatdata checkbox. | |||
There was a problem hiding this comment.
It doesn't make sense to repeat and rephrase what the code does as a comment. And it is also inconsistent to insert a comment only here but not at the other place. Please remove it.
|
Please get familiar with Git before opening any new PRs. Such a trivial fix is not worth all this noise and waste of time for everyone that is involved. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Its not that I am not familiar with Git, its that I am trying to adapt Mixxx's coding style i know that in a few days I 'll be better, sorry for inconvenience! |
|
Do you have git installed locally? On which OS are you? If you feel uncertain with git. I strongly recommend to do: |
|
I am on Linux(Kubuntu), and I am travelling right now will push the changes after few hours, as I told ealier I am familiar with git, I understood the above command after the rebase there will be merge conflicts too that I will be needing to resolve and then I will push the updated changes, I am taking time because of my travelling issues. |
|
Thank you for your concerns! |
|
Thank you. Please squash the two commits to get rid of the kdev4 file. |
|
What worked for me was: |
|
Okay. Squashing can be done when rebasing interactively (-i) |
|
@tech-bash |
|
This is a last minute 2.3.5 candidate |
|
I con confirm that @tech-bash has signed the contributor agreement. Do you have interest to fix the CI so that we can include this in the next release? |
|
Closed via #11782. Thank you. |
Fix: #11226
Its working perfectly as wanted.