Revive #11441 #11782
Revive #11441 #11782
Conversation
|
This can be also fixed in 2.3. Did you consider this? I think the logic is already implemented in the back-end that the "SeratoMetadataExport" config is only used if "SyncTrackMetadataExport" is enabled. This is a visual fix at the right place IMHO. In addition, this PR resets the value of "SeratoMetadataExport". So that after cycling "SyncTrackMetadataExport", "SeratoMetadataExport" is off. Bug or feature? |
Right, I wanted to show that disabling metadata export will disable serato export as well. Just making the checkbox unclickable was not enough of an indication for me since it still looked like it was enabled, just not changeable by the user.
Not sure either, I'd consider this "minor visual polishing". I don't care what branch it goes into, I just wanted to close the abandoned PR this is based on. What branch would you like this to be targeted at? |
|
I would prefer to merge this to 2.3. if this is not to much hassle for you. Just graying out the checkbox does not work. It need to be grayed out and unchecked. From UX perspective, it should be the "old state" to decouple dependencies, but if we have good reasons for a difference choice it is also fine. |
This will make the behavior clear visually that serato metadata can only be exported if the general metadata export is also enabled.
|
done, but expect merge conflicts when merging to 2.4. |
|
Thank you |
Fixes #11226, Supersedes #11441
I added another little feature where it disables the serato metadata export when the general metadata export is also disabled. I'm not sure if enforcing that in the UI is the best solution, suggestions welcome.