-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Behringer-CMD-PL-1 controller #11518
Conversation
Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. |
@yledoare Please read this comment in one of your abandoned previous CMD-PL-1 PRs
Please also open a PR with the mapping documentation for the manual https://github.com/mixxxdj/manual/ |
Done ! |
You don't need to rebase, commit history looks good after I changed the base branch here. |
@yledoare thank you for retrying to submit this PR. Please follow the steps described by ronso0 in #11518 (comment) Thank you. |
For the case, taht you don't know how to use Git, here is an article how to do these steps: |
Please execute the steps in the order listed above, otherwise you will do everything twice. |
This PR is based on main (likely quite outdated) but merging into 2.3. This is messing with our checks... |
New PR from 2.3 branch : #11529 |
@yledoare Why do yo keep creating new PRs instead of following given advice? Setting up pre-commit and rebasing are skills you need anyway sooner or later.
|
Hello,
This is a code that didn't be included in my last PR
I hope now it will be OK
Regards