Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Behringer-CMD-PL-1 controller #11518

Closed
wants to merge 4 commits into from
Closed

Add Behringer-CMD-PL-1 controller #11518

wants to merge 4 commits into from

Conversation

yledoare
Copy link

Hello,
This is a code that didn't be included in my last PR
I hope now it will be OK
Regards

@JoergAtGithub
Copy link
Member

Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@ronso0
Copy link
Member

ronso0 commented Apr 29, 2023

@yledoare Please read this comment in one of your abandoned previous CMD-PL-1 PRs
#3246 (comment)

  • install pre-commit
  • rebase your branch onto Mixxx 2.3
  • run pre-commit
  • apply changes the proposed changes, ammend those to your first commit
  • and finally force-push

Please also open a PR with the mapping documentation for the manual https://github.com/mixxxdj/manual/

@yledoare
Copy link
Author

Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Done !

@ronso0 ronso0 changed the base branch from main to 2.3 April 29, 2023 11:18
@ronso0
Copy link
Member

ronso0 commented Apr 29, 2023

rebase your branch onto Mixxx 2.3

You don't need to rebase, commit history looks good after I changed the base branch here.

@Swiftb0y
Copy link
Member

@yledoare thank you for retrying to submit this PR. Please follow the steps described by ronso0 in #11518 (comment)

Thank you.

@JoergAtGithub
Copy link
Member

For the case, taht you don't know how to use Git, here is an article how to do these steps:

@JoergAtGithub
Copy link
Member

Please execute the steps in the order listed above, otherwise you will do everything twice.

@Swiftb0y
Copy link
Member

This PR is based on main (likely quite outdated) but merging into 2.3. This is messing with our checks...

@yledoare
Copy link
Author

yledoare commented May 2, 2023

New PR from 2.3 branch : #11529

@yledoare yledoare closed this May 2, 2023
@ronso0
Copy link
Member

ronso0 commented May 2, 2023

@yledoare Why do yo keep creating new PRs instead of following given advice? Setting up pre-commit and rebasing are skills you need anyway sooner or later.

For the case, taht you don't know how to use Git, here is an article how to do these steps:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants