Add Behringer-CMD-PL-1 controller #11529
Conversation
|
Tthe mapping test fails: https://github.com/mixxxdj/mixxx/actions/runs/4859672642/jobs/8663843593?pr=11529 You need to install and run pre-commit as adviced multiple times there #11518 (comment) |
|
I have this error on pre-commit don't commit to branch...................................................Failed
|
|
And when I want to make tests, I have a timeout 1/650 Test #1: AnalyzerWaveformTest.simpleAnalyze ..............................................***Timeout 1500.13 sec Maybe because I need a defined DISPLAY ? |
That is because you named your branch like the target. You can skip this hook with |
|
But |
|
@yledoare May I ask what your intention is with this PR? Do you need help with mapping it or is this supposed to be a complete submission? |
There was a problem hiding this comment.
I'm sorry, I can't accept the PR in this state. Only 10% of the hardware is actually mapped and the implementation is sloppy and full of errors to the point where I doubt this mapping has ever even been tested. @yledoare if you want to make a helpful contribution, please take the time to get familiar with our documentation, XML and Javascript so you can create a usable and polished mapping.
| <key>play</key> i | ||
| <description>Play</description> i | ||
| <status>0x90</status> i |
| <forums>https://mixxx.discourse.group/t/behringer-cmd-pl-1/15755/2</forums> | ||
| <wiki>https://github.com/mixxxdj/mixxx/wiki/Behringer%20CMD%20PL-1</wiki> |
There was a problem hiding this comment.
The forum post references a completely different mapping. The wiki page is basically empty.
| <control> | ||
| <group>[Channel1]</group> | ||
| <key>play</key> i | ||
| <description>Play</description> i | ||
| <status>0x90</status> i | ||
| <midino>0x23</midino> | ||
| <options> <switch/> </options> | ||
| </control> | ||
| <control> | ||
| <group>[Channel2]</group> | ||
| <key>play</key> | ||
| <description>Play</description> | ||
| <status>0x91</status> | ||
| <midino>0x23</midino> | ||
| <options> <switch/> </options> | ||
| </control> |
There was a problem hiding this comment.
why the mapping to two different channels?
these should be <normal/> and probably also need a midi note-off mapping.
| }; | ||
|
|
||
| CMDPL1.pitchSlider = function(channel, control, value, status, group) { // Lower the sensitivity of the pitch slider | ||
| const currentValue = engine.getValue(group, "rate"); |
There was a problem hiding this comment.
you don't need the this, and please remove the unnecessary comments.
| let deckNumber = script.deckFromGroup(group); | ||
| //print("> value : "+deckNumber); | ||
|
|
||
| // A: For a control that centers on 0: | ||
| let newValue; | ||
| if (value < 64) { | ||
| newValue = value; | ||
| } else { | ||
| newValue = value - 128; | ||
| } | ||
|
|
||
| // B: For a control that centers on 0x40 (64): | ||
| newValue = value - 64; | ||
|
|
||
| // --- End choice | ||
|
|
||
| // In either case, register the movement | ||
| deckNumber = script.deckFromGroup(group); | ||
| if (engine.isScratching(deckNumber)) { | ||
| engine.scratchTick(deckNumber, newValue); // Scratch! | ||
| } else { | ||
| engine.setValue(group, "jog", newValue); // Pitch bend | ||
| } |
There was a problem hiding this comment.
you were only supposed to use either implementation, nevertheless, actually scratching won't work either because you never actually map the wheeltouch.
|
This PR is marked as stale because it has been open 90 days with no activity. |
github-actions
bot
added
the
stale
|
closing this PR as the author seems to be too negligent to follow the basic tutorial and too unresponsive to respond to review comments. |
|
It's been 3 years to include a mapping into the code. Cool No wonder people give up |
Hello,
this a pull request from 2.3 branch
I hope this fix the PR 11518
Regards