Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComponentJS: make JogWheelBasic correctly switch which deck it controls #11913

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

miwig
Copy link
Contributor

@miwig miwig commented Sep 3, 2023

by getting the deck from the group in connect. Fixes #11867. Please let me know if any changes are needed @Swiftb0y.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
by getting the deck from the `group` in `connect`
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request. Also, we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. Thank you.

res/controllers/midi-components-0.0.js Show resolved Hide resolved
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>
@miwig
Copy link
Contributor Author

miwig commented Sep 3, 2023

Small request. Also, we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. Thank you.

Signed.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Swiftb0y Swiftb0y merged commit 72512c5 into mixxxdj:2.4 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants