Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update eslint jsdoc plugin to avoid crash on jsdoc'd files #11917

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Sep 4, 2023

fixes the failing pre-commit runs on PRs such as #11913 #11910 (example failing job: https://github.com/mixxxdj/mixxx/actions/runs/6065922549/job/16456428918?pr=11913)

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sound reasonable let's give it a try.

@daschuer daschuer merged commit 4b42912 into mixxxdj:2.4 Sep 4, 2023
@Swiftb0y Swiftb0y deleted the fix/eslint-crash branch September 4, 2023 21:34
@Swiftb0y
Copy link
Member Author

Swiftb0y commented Sep 4, 2023

Pretty sure that it fixes it because I was able to reproduce the issue locally and confirmed an update to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants