Improve sorting in the track tables BPM Options submenu #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort by the most used options and add some separators for clarity. Also rename the submenu from BPM Settings > BPM Options. IMO this is the more correct term since the menu contains the available options for the BPM setting of a track.
| @@ -66,7 +66,7 @@ | |||
| m_pCrateMenu = new QMenu(this); | |||
| m_pCrateMenu->setTitle(tr("Add to Crate")); | |||
| m_pBPMMenu = new QMenu(this); | |||
| m_pBPMMenu->setTitle(tr("BPM Settings")); | |||
| m_pBPMMenu->setTitle(tr("BPM Options")); | |||
There was a problem hiding this comment.
Though it's not only for adjusting since you can lock/clear.
|
Other than that one note, LGTM. |
|
LGTM |
Merge branch 'mixxxdj/mixxx/tree/master' into 'esbrandt/mixxx/tree/master' Conflicts: mixxx/src/widget/wtracktableview.cpp
…rackeditor window. It also adds some tooltips and fixes the tab order. Could use some wordsmithing on the tooltips though. Thanks.
|
|
|
can you order them in a 2x2 grid. Otherwise I think it's nice |
|
|
|
perfect |
rryan
added a commit
that referenced
this pull request
Jun 25, 2013
Improve sorting in the track tables BPM Options submenu
Merged
ronso0
referenced
this pull request
in ronso0/mixxx
Oct 25, 2017
fix positions of mixer controls, rearrange vinyl controls
11 tasks
Closed
Holzhaus
referenced
this pull request
in Holzhaus/mixxx
Aug 23, 2020
Add `Edit metadata of audio files` chapter, including informations on … * Track Inline editing * Properties editor * MusicBrainz lookup. Fixes mixxxdj/manual#9
ywwg
pushed a commit
that referenced
this pull request
Mar 7, 2022
…h sync
When loading a track that is not yet present in the library (and thus
doesn't have any BPM because it hasn't been analyzed yet) while another
deck is playing and both decks have sync enabled, a debug assertion is
triggered:
DEBUG ASSERT: "isValid()" in function double mixxx::Bpm::value() const at src/track/bpm.h:53
Aborted (core dumped)
The backtrace looks as follows:
#0 0x00007f175c87234c in __pthread_kill_implementation () at /usr/lib/libc.so.6
#1 0x00007f175c8254b8 in raise () at /usr/lib/libc.so.6
#2 0x00007f175c80f534 in abort () at /usr/lib/libc.so.6
#3 0x00007f175cf05ee4 in qt_assert(char const*, char const*, int) () at /usr/lib/libQt5Core.so.5
#4 0x000055deb2e67e1c in mixxx::(anonymous namespace)::handleMessage(QtMsgType, QMessageLogContext const&, QString const&) (type=<optimized out>, context=<optimized out>, input=<optimized out>) at src/util/logging.cpp:355
#5 0x00007f175cf47128 in () at /usr/lib/libQt5Core.so.5
#6 0x00007f175cf3fd8a in () at /usr/lib/libQt5Core.so.5
#7 0x00007f175cf06526 in QMessageLogger::critical(char const*, ...) const () at /usr/lib/libQt5Core.so.5
#8 0x000055deb2e5c720 in mixxx_debug_assert(char const*, char const*, int, char const*) (assertion=assertion@entry=0x55deb39bd0db "isValid()", file=file@entry=0x55deb39bbf30 "src/track/bpm.h", line=line@entry=53, function=function@entry=0x55deb39bbf08 "double mixxx::Bpm::value() const") at gsrc/util/assert.h:9
#9 0x000055deb2ee7e7e in mixxx_debug_assert_return_true(char const*, char const*, int, char const*) (function=0x55deb39bbf08 "double mixxx::Bpm::value() const", line=53, file=0x55deb39bbf30 "src/track/bpm.h", assertion=0x55deb39bd0db "isValid()") at gsrc/util/assert.h:18
#10 mixxx::Bpm::value() const (this=<synthetic pointer>) at src/track/bpm.h:53
#11 mixxx::operator*(mixxx::Bpm, double) (multiple=1, bpm=...) at src/track/bpm.h:160
#12 SyncControl::setLocalBpm(mixxx::Bpm) (this=<optimized out>, localBpm=...) at src/engine/sync/synccontrol.cpp:567
#13 0x000055deb34c7ba3 in EngineBuffer::postProcess(int) (this=0x55deb56eb060, iBufferSize=2048) at src/engine/enginebuffer.cpp:1318
#14 0x000055deb3139023 in EngineMaster::processChannels(int) (this=0x55deb5449440, iBufferSize=<optimized out>) at src/engine/enginemaster.cpp:383
#15 0x000055deb31394f7 in EngineMaster::process(int) (this=0x55deb5449440, iBufferSize=iBufferSize@entry=2048) at src/engine/enginemaster.cpp:410
#16 0x000055deb2f91d0b in SoundManager::onDeviceOutputCallback(long) (this=<optimized out>, iFramesPerBuffer=iFramesPerBuffer@entry=1024) at src/soundio/soundmanager.cpp:596
#17 0x000055deb32dd794 in SoundDevicePortAudio::callbackProcessClkRef(long, float*, float const*, PaStreamCallbackTimeInfo const*, unsigned long) (this=0x55deb553e6b0, framesPerBuffer=1024, out=<optimized out>, in=<optimized out>, timeInfo=<optimized out>, statusFlags=<optimized out>) at src/soundio/sounddeviceportaudio.cpp:965
This happens because `newLocalBpm` is invalid when `localBpm` is
invalid. Trying to do sync decks while no tempo information is available
does not make sense, so we only synchronize decks if the local BPM is
available.
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Add Ubuntu 16.04 Xenial as supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort by the most used options and add some separators for clarity.
Also rename the submenu from BPM Settings > BPM Options. IMO this is
the more correct term since the menu contains the available options for
the BPM setting of a track.
PS. A test to see how forks and pull request work. New to this.