Multi-broadcasting #1300

Palakis · 2017-07-03T07:06:38Z

These contributions add the ability to do Live Broadcasting to several servers simultaneously from Mixxx.
This is phase 2 and 3 of my GSoC project for Mixxx and is based on the work done on XML live broadcasting profiles during phase 1 of GSoC.

Tasks:

Implement ShoutConnection
- Set broadcasting profile
- Start output
- Stop output
- Push audio samples to encoder then output
Refactor streaming engine
- Internal output instances list
- Push received samples to outputs
- Connection list synchronization with BroadcastSettings' profile list
- Proper buffer sync management in EngineNetworkStream
Live Broadcastings preferences UI refactor
- List/table view of all outputs/connections
  - Correct column sizing
  - Show connection state
  - Colorful connection states
- "Create connection" button
- Enable/disable a connection
- Changes saved only on Apply
- Edit settings for a connection
- Rename a connection
- Remove a connection
  - Better removal UX

I initially forgot to add broadcastprofile.cpp into the list of source files in build/depends.py, so I didn't noticed all the errors and mistakes I've made while writing this earlier. This commit aims to fix these errors and have the BroadcastProfile class to build.

No idea if this works. I just want to make sure it is saved somewhere out of my computer. I may squash this with other commits later.

Both ways didn't handled the document's root tag. Now, profile values are saved properly.

…ast-profiles

This isn't needed in the current state of the code.

These additions automatically fetches existing Live Broadcasting preferences from mixxx.cfg, puts them in the Default Profile and removes the now useless keys from mixxx.cfg

Add more tests in the process, because the regex changed.

Palakis · 2017-11-18T20:34:52Z

@daschuer

Do you plan to ad the "disconnect all" Button to the preferences? I think it would be nice, but no blocking feature.

Implemented!

Palakis · 2017-11-18T21:02:19Z

@ronso0 @Be-ing Fixed the merge conflicts with Tango. Did additional changes, tested all 5 Live Broadcasting states show properly in Tango's UI.

Be-ing · 2017-11-18T21:10:22Z

Great! @daschuer is this ready for merge? If there are minor issues that remain, I think we should merge it already and file bugs for the remaining issues.

Palakis · 2017-11-18T21:14:11Z

@Be-ing Thanks! Understood.

Palakis · 2017-11-18T21:17:34Z

Once this PR gets merged, it will be possible to open PRs for the new Opus and HE-AAC encoders, as their branches are based on this one.

daschuer · 2017-11-19T01:42:19Z

Thank you, I have tested it once again, and it works good.
Some minor issues:

I think the connection checkboxes should remain unchanged when disconnecting all.
Do we really need the warning dialogue? I am unsure, it was surprising for me.
The tango icon changes to "off air" during mouse hoover

JosepMaJAZ · 2017-11-19T10:39:44Z

@JosepMaJAZ That's a weird issue... What platform are you running this build of Mixxx on? When this error happened, were you running the latest version of this branch?

@Palakis That was on Windows, and using the build generated by AppVeyor for this PR.
Oh, and I used the Menu entry to enable broadcasting.

Palakis · 2017-11-19T11:56:45Z

@daschuer

Do we really need the warning dialogue? I am unsure, it was surprising for me.

It's better to ask the user for confirmation.

The tango icon changes to "off air" during mouse hoover

This is already the case in upstream. I just updated it to support the new button states.

Palakis · 2017-11-19T13:12:13Z

@daschuer

I think the connection checkboxes should remain unchanged when disconnecting all.

Fixed. Actually turning broadcasting off now instead of disabling every connection.

Palakis · 2017-11-20T20:02:37Z

Merge conflicts originating from the merge of networkclockref into Mixxx's master: fixed!

daschuer · 2017-11-20T23:12:42Z

LGTM! Thank you very much! This is really a nice feature for Mixxx that really matters for the broadcasting users.
I am looking forward to the next broadcasting related PRs ;-)

daschuer · 2017-11-20T23:20:01Z

Now we have failing tests. It looks like a kind of merge conflict ... The similar is reported for #1377 (comment)

daschuer · 2017-11-20T23:23:59Z

Master is Failing as well. So we can merge this.

JosepMaJAZ · 2017-11-26T19:27:39Z

I know this has already been merged, but I have discovered a bug in it.
If you have multiple connections and go to preferences, initially there is no connection selected, but the settings show data of one of the connections. (in my case, it was the second of two connections, which was the last that I had been editing)

If the users modifies any data, this data is not saved, so the changes are lost.
Either, when loading the dialog, select the first and load its data, or disable editing of the data until a selection has been made (probably, it's easier to do the first).

Side note: The whole preference page talks about connections, but the correct term is sources (or source connection if you preffer). That's what I've been using in the translations I've done.

JosepMaJAZ · 2017-12-08T11:28:31Z

Another bug reported by an user on the boards. The setting for "Dynamically Update Ogg Vorbis Metadata" is not being saved to the config:
https://mixxx.org/forums/viewtopic.php?f=3&t=9496&view=unread#unread

Palakis · 2017-12-08T12:15:55Z

Thanks for the report. Gonna investigate these and open a PR with fixes for these issues.

Palakis · 2017-12-16T14:46:06Z

Issues fixed, see PR #1418.

Palakis added 30 commits June 2, 2017 14:45

preferences: add WIP class for broadcasting profiles

b75dc85

xml profile schema: refactor tag names to SnakeCase

eb7a29d

(WIP) BroadcastSettings and BroadcastProfile refactor

6449956

No idea if this works. I just want to make sure it is saved somewhere out of my computer. I may squash this with other commits later.

BroadcastSettings: fix behaviour of filename gen. method

afff79f

BroadcastProfile: fix XML load/save code

744cb93

Both ways didn't handled the document's root tag. Now, profile values are saved properly.

BroadcastSettings: enhance default profile creation

c1296be

BroadcastSettings: add qDebug statements

52f8d7e

BroadcastProfile: remove extra qualifications in header file

84dd954

Merge branch 'master' of https://github.com/mixxxdj/mixxx into broadc…

607bab5

…ast-profiles

BroadcastProfile: fix XML file load code

b2d089d

BroadcastSettings: make sure only one instance exists

29e2205

Code style fix in EncoderBroadcastSettings

0ee0095

SettingsManager: remove shared pointer type

6196f40

This isn't needed in the current state of the code.

Add auto migration from legacy broadcasting settings

48fd2f2

These additions automatically fetches existing Live Broadcasting preferences from mixxx.cfg, puts them in the Default Profile and removes the now useless keys from mixxx.cfg

Broadcasting settings: don't remove previous settings when migrating

9114789

Move BroadcastProfile::loadLegacySettings to BroadcastSettings

cb2ed7b

Unindent anonymous namespace of BroadcastProfile class

679b61d

BroadcastProfile: remove non-existent method declaration

0c8392c

Add unit tests for BroadcastProfile class

39cc28a

Fix and rename method BroadcastProfile::checkNameCompliance

ab14026

BroadcastProfile: fix DefaultValues unit test

c6e0af9

BroadcastProfile: fix typo in forbidden characters regex

38c9b1d

Add more tests in the process, because the regex changed.

BroadcastProfile: fix forbidden chars regex syntax

1f2452d

Several minor fixes in BroadcastProfile class

e590364

Use a QSharedPointer smart pointer for instances of BroadcastProfile

0b85dea

Several changes in BroadcastSettings class

5057479

Minor fixes in DlgPrefBroadcast

6d4e369

BroadcastProfile: replace use of QSharedPointer with std::unique_ptr

7ddba28

BroadcastSettings: hashmap for fast lookup of profiles by name

799dc4e

Palakis added 2 commits November 18, 2017 21:59

Tango: rename Warning image file

f5a8de3

Tango: fix LB button type

43ba5e0

"Disconnect all" button new behaviour: turn broadcasting off

f23e55a

Palakis mentioned this pull request Nov 20, 2017

Optional network clock reference #894

Merged

Palakis and others added 2 commits November 20, 2017 19:36

Merge branch 'master' into multi-broadcasting

19cbee3

SoundDeviceNetwork: fix errors

993d0cb

daschuer merged commit 7bf4209 into mixxxdj:master Nov 20, 2017

Be-ing mentioned this pull request Nov 21, 2017

Tango :: box for Pitch slider, improve skin menu, fix glitches #1380

Merged

Palakis mentioned this pull request Dec 16, 2017

Multi-broadcasting: fix reported issues #1418

Merged

ronso0 mentioned this pull request Aug 24, 2020

Stream_name: Adding a default stream name to the Stream Info. #3043

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multi-broadcasting #1300

Multi-broadcasting #1300

Palakis commented Jul 3, 2017 •

edited

Loading

Palakis commented Nov 18, 2017

Palakis commented Nov 18, 2017

Be-ing commented Nov 18, 2017 •

edited

Loading

Palakis commented Nov 18, 2017

Palakis commented Nov 18, 2017

daschuer commented Nov 19, 2017

JosepMaJAZ commented Nov 19, 2017

Palakis commented Nov 19, 2017

Palakis commented Nov 19, 2017

Palakis commented Nov 20, 2017

daschuer commented Nov 20, 2017

daschuer commented Nov 20, 2017

daschuer commented Nov 20, 2017

JosepMaJAZ commented Nov 26, 2017

JosepMaJAZ commented Dec 8, 2017

Palakis commented Dec 8, 2017

Palakis commented Dec 16, 2017

Multi-broadcasting #1300

Multi-broadcasting #1300

Conversation

Palakis commented Jul 3, 2017 • edited Loading

Palakis commented Nov 18, 2017

Palakis commented Nov 18, 2017

Be-ing commented Nov 18, 2017 • edited Loading

Palakis commented Nov 18, 2017

Palakis commented Nov 18, 2017

daschuer commented Nov 19, 2017

JosepMaJAZ commented Nov 19, 2017

Palakis commented Nov 19, 2017

Palakis commented Nov 19, 2017

Palakis commented Nov 20, 2017

daschuer commented Nov 20, 2017

daschuer commented Nov 20, 2017

daschuer commented Nov 20, 2017

JosepMaJAZ commented Nov 26, 2017

JosepMaJAZ commented Dec 8, 2017

Palakis commented Dec 8, 2017

Palakis commented Dec 16, 2017

Palakis commented Jul 3, 2017 •

edited

Loading

Be-ing commented Nov 18, 2017 •

edited

Loading