Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-broadcasting #1300

Merged
merged 187 commits into from
Nov 20, 2017
Merged

Multi-broadcasting #1300

merged 187 commits into from
Nov 20, 2017

Commits on Jun 2, 2017

  1. preferences: add WIP class for broadcasting profiles

    Palakis committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    b75dc85 View commit details
    Browse the repository at this point in the history

  2. xml profile schema: refactor tag names to SnakeCase

    Palakis committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    eb7a29d View commit details
    Browse the repository at this point in the history

  3. Fix errors in BroadcastProfile and make sure it builds 

    I initially forgot to add broadcastprofile.cpp into the list
of source files in build/depends.py, so I didn't noticed all the
errors and mistakes I've made while writing this earlier.
This commit aims to fix these errors and have the BroadcastProfile
class to build.
    Palakis committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    abc8b81 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2017

  1. (WIP) BroadcastSettings and BroadcastProfile refactor 

    No idea if this works. I just want to make sure it is saved
somewhere out of my computer.
I may squash this with other commits later.
    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    6449956 View commit details
    Browse the repository at this point in the history

  2. BroadcastSettings: fix behaviour of filename gen. method

    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    afff79f View commit details
    Browse the repository at this point in the history

  3. BroadcastProfile: fix XML load/save code 

    Both ways didn't handled the document's root tag.
Now, profile values are saved properly.
    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    744cb93 View commit details
    Browse the repository at this point in the history

  4. BroadcastSettings: enhance default profile creation

    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    c1296be View commit details
    Browse the repository at this point in the history

  5. BroadcastSettings: add qDebug statements

    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    52f8d7e View commit details
    Browse the repository at this point in the history

  6. BroadcastProfile: remove extra qualifications in header file

    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    84dd954 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of https://github.com/mixxxdj/mixxx into broadc… 

    …ast-profiles
    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    607bab5 View commit details
    Browse the repository at this point in the history

  8. BroadcastProfile: fix XML file load code

    Palakis committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    b2d089d View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2017

  1. BroadcastSettings: make sure only one instance exists

    Palakis committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    29e2205 View commit details
    Browse the repository at this point in the history

  2. Code style fix in EncoderBroadcastSettings

    Palakis committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    0ee0095 View commit details
    Browse the repository at this point in the history

  3. SettingsManager: remove shared pointer type 

    This isn't needed in the current state of the code.
    Palakis committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    6196f40 View commit details
    Browse the repository at this point in the history

  4. Add auto migration from legacy broadcasting settings 

    These additions automatically fetches existing
Live Broadcasting preferences from mixxx.cfg, puts
them in the Default Profile and removes the now
useless keys from mixxx.cfg
    Palakis committed Jun 15, 2017
    14 Configuration menu
    Copy the full SHA
    48fd2f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2017

  1. Broadcasting settings: don't remove previous settings when migrating

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    9114789 View commit details
    Browse the repository at this point in the history

  2. Move BroadcastProfile::loadLegacySettings to BroadcastSettings

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    cb2ed7b View commit details
    Browse the repository at this point in the history

  3. Unindent anonymous namespace of BroadcastProfile class

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    679b61d View commit details
    Browse the repository at this point in the history

  4. BroadcastProfile: remove non-existent method declaration

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    0c8392c View commit details
    Browse the repository at this point in the history

  5. Add unit tests for BroadcastProfile class

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    39cc28a View commit details
    Browse the repository at this point in the history

  6. Fix and rename method BroadcastProfile::checkNameCompliance

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    ab14026 View commit details
    Browse the repository at this point in the history

  7. BroadcastProfile: fix DefaultValues unit test

    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    c6e0af9 View commit details
    Browse the repository at this point in the history

  8. BroadcastProfile: fix typo in forbidden characters regex 

    Add more tests in the process, because the regex changed.
    Palakis committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    38c9b1d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2017

  1. BroadcastProfile: fix forbidden chars regex syntax

    Palakis committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    1f2452d View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. Several minor fixes in BroadcastProfile class

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    e590364 View commit details
    Browse the repository at this point in the history

  2. Use a QSharedPointer smart pointer for instances of BroadcastProfile

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    0b85dea View commit details
    Browse the repository at this point in the history

  3. Several changes in BroadcastSettings class

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    5057479 View commit details
    Browse the repository at this point in the history

  4. Minor fixes in DlgPrefBroadcast

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    6d4e369 View commit details
    Browse the repository at this point in the history

  5. BroadcastProfile: replace use of QSharedPointer with std::unique_ptr

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    7ddba28 View commit details
    Browse the repository at this point in the history

  6. BroadcastSettings: hashmap for fast lookup of profiles by name

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    799dc4e View commit details
    Browse the repository at this point in the history

  7. BroadcastProfile: loadFromFile returns a smart pointer

    Palakis committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    337b260 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2017

  1. Remove uses of C++14 std::make_unique

    Palakis committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    0676416 View commit details
    Browse the repository at this point in the history

  2. Revert removal of std::make_unique and use it properly

    Palakis committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    b9806f6 View commit details
    Browse the repository at this point in the history

  3. Use QSharedPointers instead of std::unique_ptr and add missing connec… 

    …t call

BroadcastProfile notifies name changes to BroadcastSettings with Qt's signals &
slots system. However Qt is not compatible with the std::unique_ptr smart
pointer. A refactor of BroadcastProfilePtr is required to make it compatible.
std::unique_ptr has been replaced with QSharedPointer, as this type is easy
to pass around in the code while keeping a reference to the original pointer
and deleting it when not used anymore.
    Palakis committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    7d4fdd6 View commit details
    Browse the repository at this point in the history

  4. Refactor BroadcastProfile ForbiddenChars unit test

    Palakis committed Jun 21, 2017
    Configuration menu
    Copy the full SHA
    4c55ae6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2017

  1. BroadcastProfile tests: remove deprecated asserts

    Palakis committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    43468cd View commit details
    Browse the repository at this point in the history

  2. BroadcastProfile: add clarifying comment

    Palakis committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    50e542b View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2017

  1. BroadcastSettings: implement model and remove get/setCurrentProfile

    Palakis committed Jun 23, 2017
    Configuration menu
    Copy the full SHA
    f4d10b7 View commit details
    Browse the repository at this point in the history

  2. BroadcastProfile unit testing: use regular tests

    Palakis committed Jun 23, 2017
    Configuration menu
    Copy the full SHA
    113108d View commit details
    Browse the repository at this point in the history

  3. BroadcastProfile tests: remove useless fixture

    Palakis committed Jun 23, 2017
    Configuration menu
    Copy the full SHA
    57e9047 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2017

  1. Merge branch 'master' of https://github.com/mixxxdj/mixxx

    @Palakis
    Palakis committed Jun 24, 2017
    Configuration menu
    Copy the full SHA
    266007f View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2017

  1. (WIP) Preliminary work on ShoutOutput and EngineBroadcast refactor 

    Building this will fail.
    @Palakis
    Palakis committed Jul 4, 2017
    2 Configuration menu
    Copy the full SHA
    c7382d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2017

  1. ShoutOutput: Fix header closing comment

    @Palakis
    Palakis committed Jul 5, 2017
    Configuration menu
    Copy the full SHA
    6917d7e View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2017

  1. Various fixes

    @Palakis
    Palakis committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    8c03902 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2017

  1. Tidying up from the refactor

    @Palakis
    Palakis committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    6e5fa01 View commit details
    Browse the repository at this point in the history

  2. BroadcastProfile: add valuesCopy() and equals() method 

    equals() compares two instances of BroadcastProfile for equality.
valuesCopy() copies all values of the instance to a new one.
    @Palakis
    Palakis committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    b9cb248 View commit details
    Browse the repository at this point in the history

  3. EngineBroadcast sync with BroadcastSettings

    @Palakis
    Palakis committed Jul 7, 2017
    Configuration menu
    Copy the full SHA
    be407b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2017

  1. ShoutOutput: start/stop connection on settings apply

    @Palakis
    Palakis committed Jul 9, 2017
    Configuration menu
    Copy the full SHA
    f1bf7f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2017

  1. DlgPrefBroadcast: new UI setup 

    Mostly imported from the broadcast-profiles branch, with some compatibility
changes for the latest codebase. There's one known crash currently.
    @Palakis
    Palakis committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    d595cf2 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2017

  1. DlgPrefBroadcast: disable unsaved changes dialog

    @Palakis
    Palakis committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    873e738 View commit details
    Browse the repository at this point in the history

  2. DlgPrefBroadcast: profile list WIP

    @Palakis
    Palakis committed Jul 12, 2017
    Configuration menu
    Copy the full SHA
    1b7bfdd View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2017

  1. DlgPrefBroadcast: push values to profile on list selection or apply

    @Palakis
    Palakis committed Jul 16, 2017
    Configuration menu
    Copy the full SHA
    a75bb17 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2017

  1. DlgPrefBroadcast: basic enable/disable + rename

    @Palakis
    Palakis committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    11fb342 View commit details
    Browse the repository at this point in the history

  2. Fixes in BroadcastSettings and DlgPrefBroadcast

    @Palakis
    Palakis committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    9c17eb3 View commit details
    Browse the repository at this point in the history

  3. DlgPrefBroadcast: implement profile removal

    @Palakis
    Palakis committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    aa2f52b View commit details
    Browse the repository at this point in the history

  4. BroadcastSettings: fix file removal

    @Palakis
    Palakis committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    fa050bc View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2017

  1. DlgPrefBroadcast: automatic profile naming on create

    @Palakis
    Palakis committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    01ee9e3 View commit details
    Browse the repository at this point in the history

  2. DlgPrefBroadcast: fix profile list presentation

    @Palakis
    Palakis committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    18d8004 View commit details
    Browse the repository at this point in the history

  3. Profile creation: check if profile with desired name already exists

    @Palakis
    Palakis committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    ef28060 View commit details
    Browse the repository at this point in the history

  4. Various changes in DlgPrefBroadcast 

    * Add a help message between the connections list and the settings panel
* Automatic profile name generation: fix to try another name if a candidate is already taken
* Highlight first row of connections list on init
    @Palakis
    Palakis committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    63a886b View commit details
    Browse the repository at this point in the history

  5. DlgPrefBroadcast: grey out "create connection" button during streaming

    @Palakis
    Palakis committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    c31354b View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. DlgPrefBroadcast: fix table column width

    @Palakis
    Palakis committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    e8441d1 View commit details
    Browse the repository at this point in the history

  2. Bugfix: avoid empty values when renaming a profile/connection in prefs

    @Palakis
    Palakis committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    02a51b9 View commit details
    Browse the repository at this point in the history

  3. Bugfix: show current name when renaming a broadcasting profile

    @Palakis
    Palakis committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    d402382 View commit details
    Browse the repository at this point in the history

  4. DlgPrefBroadcast: WIP on connection Removal Mode

    @Palakis
    Palakis committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    d6654d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2017

  1. BroadcastSettings: migrated profile enabled by default

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    984a8fb View commit details
    Browse the repository at this point in the history

  2. DlgPrefBroadcast: remove "values changed"-related code

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    2aad697 View commit details
    Browse the repository at this point in the history

  3. EngineBroadcast + ShoutOutput cleanup

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    f064217 View commit details
    Browse the repository at this point in the history

  4. EngineBroadcast: init connection list on construct

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    5403930 View commit details
    Browse the repository at this point in the history

  5. BroadcastProfile: add valuesEquals

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    eba67a8 View commit details
    Browse the repository at this point in the history

  6. EngineBroadcast + ShoutOutput: connect only when broadcasting is on

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    e30ae9d View commit details
    Browse the repository at this point in the history

  7. EngineBroadcast: fix duplicate connect call + some cleaning

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    f3f8267 View commit details
    Browse the repository at this point in the history

  8. EngineBroadcast: fix stalled thread

    @Palakis
    Palakis committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    3bbb715 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2017

  1. Bring back [Shoutcast],status

    @Palakis
    Palakis committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    b8de265 View commit details
    Browse the repository at this point in the history

  2. Fix debug statements in ShoutOutput

    @Palakis
    Palakis committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    8afe852 View commit details
    Browse the repository at this point in the history

  3. EngineBroadcast + ShoutOutput refactor

    @Palakis
    Palakis committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    97736f5 View commit details
    Browse the repository at this point in the history

  4. Bugfix: connections not started when enabling broadcasting

    @Palakis
    Palakis committed Jul 23, 2017
    Configuration menu
    Copy the full SHA
    62af486 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2017

  1. BroadcastProfile: remove profile name from XML document

    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    c691dde View commit details
    Browse the repository at this point in the history

  2. Cleanup tab identation

    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    875b268 View commit details
    Browse the repository at this point in the history

  3. Remove unwanted comments

    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    469ac5d View commit details
    Browse the repository at this point in the history

  4. DlgPrefBroadcast: fix orphan values editor after profile removal

    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    883f38d View commit details
    Browse the repository at this point in the history

  5. ShoutOutput: fix hardcoded channel count

    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    3157038 View commit details
    Browse the repository at this point in the history

  6. Changes in ShoutOutput 

    This is ShoutOutput's thread's responsibility to manage connecting to and disconnecting
from the streaming server.
    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    ac3d44b View commit details
    Browse the repository at this point in the history

  7. ShoutOutput: avoid semaphore infinite lock 

    The thread must be able to detect when a disconnect is signaled (profile disabled)
to properly disconnect even when no audio data is available from the engine
    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    9fb40ff View commit details
    Browse the repository at this point in the history

  8. ShoutOutput: detect if broadcasting is disabled

    @Palakis
    Palakis committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    c7090d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2017

  1. BroadcastProfile: implement optional secure password storage 

    Uses QtKeychain. Build only works on Linux currently.
    @Palakis
    Palakis committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    fbe7b25 View commit details
    Browse the repository at this point in the history

  2. Minor changes in BroadcastProfile

    @Palakis
    Palakis committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    3ea2824 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @Palakis
    Palakis committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    a7a2a81 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2017

  1. Streaming output "slow start"

    @Palakis
    Palakis committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    579b7fe View commit details
    Browse the repository at this point in the history

  2. More detailed comments in EngineBroadcast::process

    @Palakis
    Palakis committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    b0eaefc View commit details
    Browse the repository at this point in the history

  3. EngineBroadcast: handle "output stalled" case

    @Palakis
    Palakis committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    bba4a7f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2017

  1. Secure password in XML profiles: store accounts instead of K/V pairs

    @Palakis
    Palakis committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    3466215 View commit details
    Browse the repository at this point in the history

  2. Add Ubuntu dependency for Travis builds

    @Palakis
    Palakis committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    96cd4e2 View commit details
    Browse the repository at this point in the history

  3. Remove tabs identitation

    @Palakis
    Palakis committed Jul 31, 2017
    Configuration menu
    Copy the full SHA
    0902e5e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2017

  1. Add QtKeychain to Travis OS X builds

    @Palakis
    Palakis committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    10c4831 View commit details
    Browse the repository at this point in the history

  2. Add compile flag to enable secure password storage 

    Use qtkeychain=1 in scons to enabled this feature
    @Palakis
    Palakis committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    cdad690 View commit details
    Browse the repository at this point in the history

  3. Add optional secure credentials in Live Broadcasting profiles 

    Use qtkeychain=1 in scons to enabled this feature
    @Palakis
    Palakis authored Aug 1, 2017
    Configuration menu
    Copy the full SHA
    be375c7 View commit details
    Browse the repository at this point in the history

  4. Set qtkeychain option's default value to 0

    @Palakis
    Palakis committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    dfe6c40 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2017

  1. Refactor ShoutOutput to ShoutConnection

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    9557e7d View commit details
    Browse the repository at this point in the history

  2. Refactor EngineBroadcast as a simple pointer

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    accdb0c View commit details
    Browse the repository at this point in the history

  3. Don't pass EngineNetworkStream to EngineBroadcast

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    b89def4 View commit details
    Browse the repository at this point in the history

  4. EngineBroadcast back to QSharedPointer

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    8882d93 View commit details
    Browse the repository at this point in the history

  5. EngineNetworkStream as a unique pointer

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    f4771f9 View commit details
    Browse the repository at this point in the history

  6. Fix mistake

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    ce8afe4 View commit details
    Browse the repository at this point in the history

  7. WIP on LB connection status UI

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    84b16aa View commit details
    Browse the repository at this point in the history

  8. Connection status moved to broadcast profile

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    f4a85d7 View commit details
    Browse the repository at this point in the history

  9. Provide connection status in Live Broadcasting preferences UI

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    8401b30 View commit details
    Browse the repository at this point in the history

  10. Fix dataChanged notification triggered on connection status changes

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    c8e18cb View commit details
    Browse the repository at this point in the history

  11. Merge branch 'gsoc2017' into xmlprofile-securepassword

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    449f902 View commit details
    Browse the repository at this point in the history

  12. Add optional secure password storage in XML profiles 

    From branch 'xmlprofile-securepassword'
    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    2b455ec View commit details
    Browse the repository at this point in the history

  13. Fix include protection

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    6aff8a7 View commit details
    Browse the repository at this point in the history

  14. Minor changes

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    032dcf7 View commit details
    Browse the repository at this point in the history

  15. CI: try to fix qtkeychain OS X install

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    9023e38 View commit details
    Browse the repository at this point in the history

  16. Fix windows builds

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    a421db8 View commit details
    Browse the repository at this point in the history

  17. Revert "CI: try to fix qtkeychain OS X install" 

    This reverts commit 9023e38.
    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    1901785 View commit details
    Browse the repository at this point in the history

  18. CI: use ownCloud's Homebrew repo in OS X automated builds

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    a4b9102 View commit details
    Browse the repository at this point in the history

  19. CI: fix typo

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    6894dbd View commit details
    Browse the repository at this point in the history

  20. BroadcastProfile: update unit tests

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    f4c6846 View commit details
    Browse the repository at this point in the history

  21. CI: disable qtkeychain dependency in Travis OS X

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    fdf3078 View commit details
    Browse the repository at this point in the history

  22. Live Broadcasting: simpler connection removal

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    5631250 View commit details
    Browse the repository at this point in the history

  23. Refactor in DlgPrefBroadcast and BroadcastSettings

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    89b0251 View commit details
    Browse the repository at this point in the history

  24. Proper scons organization for the Live Broadcasting compile flag

    @Palakis
    Palakis committed Aug 4, 2017
    Configuration menu
    Copy the full SHA
    dbb5f31 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. ShoutConnection log msg fix + revert to shared pointer for netstream

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    eb613ab View commit details
    Browse the repository at this point in the history

  2. EngineBroadcast: rename channels count variable

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    fa5a846 View commit details
    Browse the repository at this point in the history

  3. DlgPrefBroadcast: remove useless reset to defaults for profiles

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    a79a858 View commit details
    Browse the repository at this point in the history

  4. DlgPrefBroadcast: "rename" button + minor design changes

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    6fdd91b View commit details
    Browse the repository at this point in the history

  5. Bugfix: profile not saved under new name when renaming

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    bd00b55 View commit details
    Browse the repository at this point in the history

  6. BroadcastSettings: remove useless const refs to QSharedPointers

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    a8ab60a View commit details
    Browse the repository at this point in the history

  7. DlgPrefBroadcast: clone values from selected connection when creating

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    b78f9b8 View commit details
    Browse the repository at this point in the history

  8. BroadcastProfile: add method adoptValues and use it in valuesCopy

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    43e95ea View commit details
    Browse the repository at this point in the history

  9. (WIP) Qt model separate from BroadcastSettings 

    This is definitely Work In Progress. Some aspects are not quite right and Mixxx could crash.
    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    0d632ec View commit details
    Browse the repository at this point in the history

  10. Small fix

    @Palakis
    Palakis committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    da0468f View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2017

  1. Fix possible crash when creating a connection

    @Palakis
    Palakis committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    194c0f2 View commit details
    Browse the repository at this point in the history

  2. Move model reset method to model class

    @Palakis
    Palakis committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    5a87fda View commit details
    Browse the repository at this point in the history

  3. DlgPrefBroadcast: fix non-working programmatic row selection code

    @Palakis
    Palakis committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    6763376 View commit details
    Browse the repository at this point in the history

  4. (WIP) Audio streaming engine refactor 

    This is a WIP to simplify and adapt the live broadcasting parts of the audio engine.

It started from this design:
Frames from audio engine => FIFO in SoundDeviceNetwork => FIFO in EngineNetworkStream
    => FIFO in EngineBroadcast => FIFOs in instances of ShoutConnection

Buffer sync is done in SoundDeviceNetwork and EngineNetworkStream, but these were designed
for a single connection. In the current implementation (multi-broadcasting branch), the buffer sync
code has no real effect on ShoutConnection instances.

New design:
Frames from audio engine => FIFO in SoundDeviceNetwork => FIFOs in instances of ShoutConnection

SoundDeviceNetwork is now aware of the several instances of ShoutConnection (as NetworkStreamWorkers), and NetworkStreamWorker now has attributes to allow buffer sync and management by SoundDeviceNetwork.
EngineNetworkStream still exists to keep the workers list and its input part (needs rework), and
EngineBroadcast has been completely deleted. Its connection list sync responsibilities with
BroadcastSettings are now honored by BroadcastManager
    @Palakis
    Palakis authored Aug 8, 2017
    Configuration menu
    Copy the full SHA
    1939347 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2017

  1. Colorful connection state

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    4c3214a View commit details
    Browse the repository at this point in the history

  2. Bugfix: erroneous connection state reset on settings apply

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    51e5095 View commit details
    Browse the repository at this point in the history

  3. DlgPrefBroadcast: fix connection list column sizes

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    1c96385 View commit details
    Browse the repository at this point in the history

  4. ShoutConnection: error and info dialog show the connection name

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    5f84f1e View commit details
    Browse the repository at this point in the history

  5. DlgPrefBroadcast: proper terminology

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    0f5c8f6 View commit details
    Browse the repository at this point in the history

  6. DlgPrefBroadcast: radio button group for password storage setting

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    61113f8 View commit details
    Browse the repository at this point in the history

  7. Secure password storage: add error dialog

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    f8b0fdd View commit details
    Browse the repository at this point in the history

  8. Change error/info dialog titles

    @Palakis
    Palakis committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    7bab140 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. DlgPrefBroadcast: disable rename button while broadcasting is active

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    84af3ae View commit details
    Browse the repository at this point in the history

  2. Replace uses of qDebug with Logger class

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    c39eecf View commit details
    Browse the repository at this point in the history

  3. NetworkStreamWorker becomes NetworkOutputStreamWorker

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    e203710 View commit details
    Browse the repository at this point in the history

  4. Fix Travis OS X builds

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    170b439 View commit details
    Browse the repository at this point in the history

  5. BroadcastSettings: fix default profile name

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    988c6dc View commit details
    Browse the repository at this point in the history

  6. EngineNetworkStream: add input worker

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    2f52925 View commit details
    Browse the repository at this point in the history

  7. Bugfix: values ignored when editing values right after opening settings

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    0d7e087 View commit details
    Browse the repository at this point in the history

  8. DlgPrefBroadcast: fix highlight color in connection list

    @Palakis
    Palakis committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    9324899 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2017

  1. BroadcastProfile: add error message on failed secure password retrieval

    @Palakis
    Palakis committed Aug 12, 2017
    Configuration menu
    Copy the full SHA
    4c262e9 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2017

  1. Bugfix: possible crash after applying changes in Live Broadcasting prefs

    @Palakis
    Palakis committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    cac95d8 View commit details
    Browse the repository at this point in the history

  2. BroadcastManager: proper Live Broadcasting status report

    @Palakis
    Palakis committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    7ff7bd6 View commit details
    Browse the repository at this point in the history

  3. DlgPrefBroadcast: prevent connection rename to existing name

    @Palakis
    Palakis committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    0ab23ed View commit details
    Browse the repository at this point in the history

  4. DlgPrefBroadcast: fix row highlight

    @Palakis
    Palakis committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    3cba5bf View commit details
    Browse the repository at this point in the history

  5. Settings model: properly relay "enabled" connection status

    @Palakis
    Palakis committed Aug 14, 2017
    Configuration menu
    Copy the full SHA
    9e499cf View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. Encoder API: update comment

    @Palakis
    Palakis committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    b99d4a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2017

  1. Fix issues with connection status and enabled status 

    - Connections don't get disabled automatically on failure anymore
- Failed connections are reset to Disconnected status when stopping broadcasting
    @Palakis
    Palakis committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    68b18b5 View commit details
    Browse the repository at this point in the history

  2. Style fix

    @Palakis
    Palakis committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    bbc7c0b View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2017

  1. Make the error messages a bit more "welcoming"

    @Palakis
    Palakis committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    0c9e770 View commit details
    Browse the repository at this point in the history

  2. Update comment in SoundDeviceNetwork

    @Palakis
    Palakis committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    1a18f75 View commit details
    Browse the repository at this point in the history

  3. Add warning state in status control object + update shade

    @Palakis
    Palakis committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    832f144 View commit details
    Browse the repository at this point in the history

  4. Update Tango with support for warning state

    @Palakis
    Palakis committed Aug 23, 2017
    Configuration menu
    Copy the full SHA
    46dd14b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into multi-broadcasting

    @Palakis
    Palakis authored Aug 23, 2017
    Configuration menu
    Copy the full SHA
    b0aefaa View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2017

  1. Broadcasting status: show failure status if all enabled conns fail

    @Palakis
    Palakis committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    d984089 View commit details
    Browse the repository at this point in the history

  2. DlgPrefBroadcast: refactor broadcasting state changes to UI

    @Palakis
    Palakis committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    e9f042a View commit details
    Browse the repository at this point in the history

  3. DlgPrefBroadcast: error if no connections enabled with turning LB on

    @Palakis
    Palakis committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    a0e7c44 View commit details
    Browse the repository at this point in the history

  4. Show failed status if Live Broadcasting is on with no enabled connection

    @Palakis
    Palakis committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    f0887c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2017

  1. Fix handling of connection selection

    @Palakis
    Palakis committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    b22fdc4 View commit details
    Browse the repository at this point in the history

  2. "Connect on apply" live broadcasting option

    @Palakis
    Palakis committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    7dd84f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2017

  1. Broadcast manager: fix LB menu entry toggle

    @Palakis
    Palakis committed Sep 4, 2017
    Configuration menu
    Copy the full SHA
    04d017c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2017

  1. Live Broadcasting prefs: mountpoint check + fix bug 

    - The Live Broadcasting preferences panel now checks on apply that two connections
to the same server don't have identical mountpoints. Comparison is based on the "host" value
but not on the actual underlying IP address if DNS names are used.
- Fixed a bug where last edited settings on the currently selected connection were
not took into account
    @Palakis
    Palakis committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    5d91aee View commit details
    Browse the repository at this point in the history

  2. Fix status updates of main menu "Enable Live Broadcasting" action

    @Palakis
    Palakis committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    abfa300 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2017

  1. Merge branch 'master' into multi-broadcasting

    @Palakis
    Palakis authored Sep 24, 2017
    Configuration menu
    Copy the full SHA
    c5ef2d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2017

  1. Bring back the "Enable Live Broadcasting" pref checkbox

    @Palakis
    Palakis committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    cfa5940 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2017

  1. LB status handling : turn off if all connections are manually disconn… 

    …ected
    @Palakis
    Palakis committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    6fdde51 View commit details
    Browse the repository at this point in the history

  2. Bring back LB "Turn LB On when applying"

    @Palakis
    Palakis committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    e2b32fc View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2017

  1. Merge branch 'master' into multi-broadcasting

    @Palakis
    Palakis committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    7c72278 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into multi-broadcasting

    @Palakis
    Palakis committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    ad83005 View commit details
    Browse the repository at this point in the history

  3. Add "Disconnect all" button

    @Palakis
    Palakis committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    4d17faa View commit details
    Browse the repository at this point in the history

  4. Tango: rename Warning image file

    @Palakis
    Palakis committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    f5a8de3 View commit details
    Browse the repository at this point in the history

  5. Tango: fix LB button type

    @Palakis
    Palakis committed Nov 18, 2017
    Configuration menu
    Copy the full SHA
    43ba5e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2017

  1. "Disconnect all" button new behaviour: turn broadcasting off

    @Palakis
    Palakis committed Nov 19, 2017
    Configuration menu
    Copy the full SHA
    f23e55a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2017

  1. Merge branch 'master' into multi-broadcasting

    @Palakis
    Palakis authored Nov 20, 2017
    Configuration menu
    Copy the full SHA
    19cbee3 View commit details
    Browse the repository at this point in the history

  2. SoundDeviceNetwork: fix errors

    @Palakis
    Palakis committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    993d0cb View commit details
    Browse the repository at this point in the history