New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-broadcasting: fix reported issues #1418

Merged

daschuer merged 3 commits into mixxxdj:master from Palakis:broadcasting-fix-161217

Dec 17, 2017

Contributor

Palakis commented Dec 16, 2017

This PR fixes two issues reported on PR #1300 and the forum (thread here) regarding the Live Broadcasting settings UI:

Connection option "Dynamically update Ogg Vorbis metadata" isn't saved. Caused by a typo (actually a copy-paste mistake) in BroadcastProfile.
Connection selection is wrong under some circumstances. This is because the settings panel calls QTableView::selectRow when updating but this method only updates the UI without triggering the expected "selection changed" signals.

Palakis added 3 commits

December 16, 2017 14:22


          Fix typo in BroadcastProfile::loadValues

5b55750


          Live Broadcasting: rename "connections" to "source connections"

16610fc


          Fix connection selection behaviour in Live Broadcasting settings

5b860ea

Palakis mentioned this pull request

Multi-broadcasting #1300

Merged

19 tasks

Member

daschuer commented Dec 17, 2017

Thank you for caring about this! LGTM

daschuer merged commit cc0770d into mixxxdj:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet