-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-track property editor / batch tag editor #12548
Conversation
80297b2
to
3de22f1
Compare
Wooh, that was easier than I expected when I took the first look a while back (actually half the time I spent on debugging stupid mistakes..) This seems to work well for all fields, |
3de22f1
to
3532411
Compare
Wow, very nice to see progress on this. Got to play around with the PR once I find some time. |
3532411
to
c8eeb80
Compare
c8eeb80
to
d9d54f4
Compare
d9d54f4
to
0fe8e31
Compare
a48e002
to
e5a1c32
Compare
@ronso0 is this ready for review? I can see couple of |
e5a1c32
to
82b4069
Compare
Thanks for taking a look! I did remove commit with (cover) trace logging and temp. stuff. There are small spots I may polish (turn DEBUG_ASSERT into VERIFY_OR_DEBUG_ASSERT) but that doesn't matter much. For further changes I'll push small commits and maybe squash them later on. |
Currently rating and color were stored immediately (not saved to tracks of course). |
Please let me know when someone starts reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my notes are addressed, thank you!
Thanks for your investigation! Please correct me if I'm wrong but I think the actual issue is I adopted it from DlgTrackInfo but actually we don't need it here at all. These are the relevant cases:
|
ff871eb
to
7ed497b
Compare
I am afraid we need clear(), to release the reference and in turn write the changes to the track file. |
build warning:
|
Okay, we can do that in the destructor.
I don't quite understand? |
I think the dialog outlives longer, is only hidden after OK. We need to take care that m_pLoadedTrack becomes nullptr, this event will then trigger the write to the file itself (if this is the last instance) Clear() in the destructor us redundant, because it is cleared anyway. |
Probably a straight forward solution is to just remove the assertion. |
Maybe you overlooked it, I explained when & how the dialog is deleted here #12548 (comment)
I don't understand. Tracks are updated in I appended a fixup that transforms the DEBUG_ASSERT (which I couldn't trigger aymore with the current state btw). |
Oh, you are right. Now everything works flawlessly. |
Alright. I noticed some issues I need to fix, though:
|
e7e0ec0
to
8cf9274
Compare
8cf9274
to
4350b46
Compare
Sooo, the key bug is fixed.
puuuh, hours of head scratching and fiddling with various SizePolicy combos... I'd appreciate another round of review if someone has the time to do so, and get this in to 2.5-alpha finally. |
I will do some end-user testing and let you know :) |
Thank you. Lets merge and test it during beta. |
I have been wanting this desperatly for ages for unifying track comments in Mixxx because the alternative workflows are a PITA, e.g. copy/paste per track, or use a tag editor and reload tags in Mixxx.
Intended to fix #9023
This is a modded/stripped clone of DlgTrackInfo, just without DlgTagFetcher and the BPM tab.
It's is not polished yet and I'll push fixes, so please don't take a too close look at the code, yet ; )
Currently supported properties
Editable fields:
Static labels:
Special fields, to be discussed:
1
(and lock) in order to 'flag' tracks as 'beatless' (athmo, fields recordings and alike) when I'm too lazy to add this to the comments.Nice to have: