View menu: add 'Show Auto DJ' action

[ronso0]

requested here https://mixxx.zulipchat.com/#narrow/stream/109122-general/topic/AutoDJ.20as.20a.20View.20option

AutoDJ is a special feature that may need immediate attention, i.e. a way to activate it quickly, that's why I think a shortcut seems reasonable.

Which keyboard shortcut?

There are already Ctrl+1..6
Ctrl+7 would be next, but maybe we want to extend the skin controls, and then it would be better to have consecutive shortcuts for toggles ("Show AutoDJ is a trigger).
What about Ctrl+9?

[fwcd]

Maybe adding the other "main" sections would make sense too, e.g. "Show Tracks"?

I'd probably lean towards a non-numeric shortcut so we can reserve those for skin controls and go for a letter (e.g. Ctrl + Alt or Shift + A?)

[ronso0]

have to reconsider this:
IIUC the idea was to quickly jump to AutoDJ when you're way down in the sidebar.
Currently this action selects AutoDJ but also scrolls there.

However, since you (maybe) only want to activate AutoDJ and then continue working in the last view (computer, history, ...), it would be helpful if the position of the sidebar were fixed. Sure, the current view would be deselected, but it would still be easy to pick up where you left off.
With Tracks or other views it could be confusing, but the AutoDJ view is recognizable.

What do you think?

Maybe adding the other "main" sections would make sense too, e.g. "Show Tracks"?

And we'd have #9912 (somehow) : )

[daschuer]

This extra indentation looks wrong. A clang-format bug? Can we workaround it?

[ronso0]

True. If I revert that clang-format insists on 8 spaces.
No idea how to work around it.

[ronso0]

Revert and ignore clang-format?

[daschuer]

Yes, I would have no issue to merge it under clang-format complains. (It should help us, not annoy us)

[ronso0]

reverted

[daschuer]

Works already :-)

[daschuer]

However, since you (maybe) only want to activate AutoDJ and then continue working in the last view (computer, history, ...), it

Correct. I played a bit with it and it reminds me to taped browsing. Search for something in the Library, verify the Auto-DJ playlist.
Continue searching.

We may emulate that by adding tabs to the sidebar ... Or a back button.

The ultimate solution "Open Auto DJ in a new Window" We have discussed the idea earlier to have a skin with two windows.

Or even allow to have two or more tabs on the library. This will allow to switch between any two contexts without headaches.

[daschuer]

I get hocked to the tapped library idea. Can we implement it with the singleton library feature in two tabs? In a first version each tap "just" need to restore the stored library table. Caveat: We cant have two tabs with the same playlist open and a saved state for each.

[ronso0]

Yes, these are nice ideas and part of the library redesign discussion.
I'm not going ot work on it : )

Here, I think we are good if we simply add something like SidebarModel::selectFeatureNoScroll(LibraryFeature* pFeature). Though this will inevtably be mostly redundant with the existing selectFeature, hmm.

[vespadj]

My suggestion

[ronso0]

Thank you, having a (additional*) topbar toggle is a good idea!
*Shade skin has no top bar, so we should always provide the action in the View menu

Note: moving widgets out of the top bar is out of scope here.
There is WIP regarding a global status bar though #3406

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.